8000 minor #28880 [HttpFoundation] Publicify new consts (ro0NL) · symfony/symfony@d813148 · GitHub
[go: up one dir, main page]
Skip to content

Commit d813148

Browse files
fabpotfabpot
committed
minor #28880 [HttpFoundation] Publicify new consts (ro0NL)
This PR was merged into the 4.2-dev branch. Discussion ---------- [HttpFoundation] Publicify new consts | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Continuation of #28807 I think it's reasonable to enforce visibility for new consts, ideally solved by PHP-CS-Fixer. This makes it explicit for the consts to be consumed as part of public API. Commits ------- ce95d0d [HttpFoundation] Publicify new consts
2 parents 76f80e9 + ce95d0d commit d813148

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

‎src/Symfony/Component/HttpFoundation/HeaderUtils.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818
*/
1919
class HeaderUtils
2020
{
21-
const DISPOSITION_ATTACHMENT = 'attachment';
22-
const DISPOSITION_INLINE = 'inline';
21+
public const DISPOSITION_ATTACHMENT = 'attachment';
22+
public const DISPOSITION_INLINE = 'inline';
2323

2424
/**
2525
* This class should not be instantiated.

0 commit comments

Comments
 (0)
0