merged branch franmomu/auto_start_default_value (PR #6155)

fabpot · fabpot · commit d6acb552ddda · 2012-12-03T23:02:45.000+01:00
This PR was submitted for the master branch but it was merged into the 2.1 branch instead (closes #6155). Commits ------- 88811f4 [FrameworkBundle] Fixed DefaultValue for session.auto_start in NodeDefinition Discussion ---------- [FrameworkBundle] Fixed DefaultValue for session.auto_start in NodeDefinition Bug fix: no Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: Todo: - License of the code: MIT Documentation PR: - This is just for consistency with the node type. --------------------------------------------------------------------------- by fabpot at 2012-11-30T07:17:33Z I don't see the need to change the default value as this is deprecated anyway. --------------------------------------------------------------------------- by franmomu at 2012-11-30T07:35:35Z I was trying to validate default values in Config Component and if I do this throws an exception
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
@@ -192,7 +192,7 @@ private function addSessionSection(ArrayNodeDefinition $rootNode)
                     ->children()
                         ->booleanNode('auto_start')
                             ->info('DEPRECATED! Session starts on demand')
-                            ->defaultNull()
+                            ->defaultFalse()
                             ->beforeNormalization()
                                 ->ifTrue(function($v) { return null !== $v; })
                                 ->then(function($v) {
