Merge branch '2.8'

nicolas-grekas · nicolas-grekas · commit d67feb4fc859 · 2015-11-04T10:24:46.000+01:00
* 2.8: [HttpKernel] Clean clock-mock injection, replaced by #16455 [Bridge\PhpUnit] Fix clock-mock registration
diff --git a/src/Symfony/Bridge/PhpUnit/SymfonyTestsListener.php b/src/Symfony/Bridge/PhpUnit/SymfonyTestsListener.php
@@ -56,6 +56,11 @@ public function startTestSuite(\PHPUnit_Framework_TestSuite $suite)
                     }
                 }
             }
+            foreach ($suite->tests() as $test) {
+                if ($test instanceof \PHPUnit_Framework_TestSuite && in_array('time-sensitive', \PHPUnit_Util_Test::getGroups($test->getName()), true)) {
+                    ClockMock::register($test->getName());
+                }
+            }
         } elseif (2 === $this->state) {
             $skipped = array();
             foreach ($suite->tests() as $test) {
diff --git a/src/Symfony/Component/HttpKernel/Tests/Fragment/FragmentHandlerTest.php b/src/Symfony/Component/HttpKernel/Tests/Fragment/FragmentHandlerTest.php
@@ -14,7 +14,6 @@
 use Symfony\Component\HttpKernel\Fragment\FragmentHandler;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Bridge\PhpUnit\ClockMock;
 
 /**
  * @group time-sensitive
@@ -25,9 +24,6 @@ class FragmentHandlerTest extends \PHPUnit_Framework_TestCase
 
     protected function setUp()
     {
-        if (class_exists('Symfony\Bridge\PhpUnit\ClockMock')) {
-            ClockMock::register('Symfony\Component\HttpFoundation\Request');
-        }
         $this->requestStack = $this->getMockBuilder('Symfony\\Component\\HttpFoundation\\RequestStack')
             ->disableOriginalConstructor()
             ->getMock()
diff --git a/src/Symfony/Component/HttpKernel/Tests/HttpCache/HttpCacheTestCase.php b/src/Symfony/Component/HttpKernel/Tests/HttpCache/HttpCacheTestCase.php
@@ -16,7 +16,6 @@
 use Symfony\Component\HttpKernel\HttpCache\HttpCache;
 use Symfony\Component\HttpKernel\HttpCache\Store;
 use Symfony\Component\HttpKernel\HttpKernelInterface;
-use Symfony\Bridge\PhpUnit\ClockMock;
 
 class HttpCacheTestCase extends \PHPUnit_Framework_TestCase
 {
@@ -33,9 +32,6 @@ class HttpCacheTestCase extends \PHPUnit_Framework_TestCase
 
     protected function setUp()
     {
-        if (class_exists('Symfony\Bridge\PhpUnit\ClockMock')) {
-            ClockMock::register('Symfony\Component\HttpFoundation\Request');
-        }
         $this->kernel = null;
 
         $this->cache = null;

Original file line number	Diff line number	Diff line change
`@@ -56,6 +56,11 @@ public function startTestSuite(\PHPUnit_Framework_TestSuite $suite)`
`56`	`56`	`}`
`57`	`57`	`}`
`58`	`58`	`}`
	`59`	`+ foreach ($suite->tests() as $test) {`
	`60`	`+ if ($test instanceof \PHPUnit_Framework_TestSuite && in_array('time-sensitive', \PHPUnit_Util_Test::getGroups($test->getName()), true)) {`
	`61`	`+ ClockMock::register($test->getName());`
	`62`	`+ }`
	`63`	`+ }`
`59`	`64`	`} elseif (2 === $this->state) {`
`60`	`65`	`$skipped = array();`
`61`	`66`	`foreach ($suite->tests() as $test) {`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,6 @@`
`16`	`16`	`use Symfony\Component\HttpKernel\HttpCache\HttpCache;`
`17`	`17`	`< 9CDD div class="diff-text-inner">use Symfony\Component\HttpKernel\HttpCache\Store;`
`18`	`18`	`use Symfony\Component\HttpKernel\HttpKernelInterface;`
`19`		`-use Symfony\Bridge\PhpUnit\ClockMock;`
`20`	`19`
`21`	`20`	`class HttpCacheTestCase extends \PHPUnit_Framework_TestCase`
`22`	`21`	`{`
`@@ -33,9 +32,6 @@ class HttpCacheTestCase extends \PHPUnit_Framework_TestCase`
`33`	`32`
`34`	`33`	`protected function setUp()`
`35`	`34`	`{`
`36`		`- if (class_exists('Symfony\Bridge\PhpUnit\ClockMock')) {`
`37`		`- ClockMock::register('Symfony\Component\HttpFoundation\Request');`
`38`		`- }`
`39`	`35`	`$this->kernel = null;`
`40`	`36`
`41`	`37`	`$this->cache = null;`