bug #53388 [Mailer] [Azure] Fix resource name validation (t9toqwerty)

OskarStark · OskarStark · commit d621936e8c63 · 2024-01-24T16:49:21.000+01:00
This PR was squashed before being merged into the 7.1 branch. Discussion ---------- [Mailer] [Azure] Fix resource name validation | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #53385 | License | MIT Remove validation where Azure Email Communication Resource with dot in name is not being allowed to use. Commits ------- 088faf5 [Mailer] [Azure] Fix resource name validation
diff --git a/src/Symfony/Component/Mailer/Bridge/Azure/Tests/Transport/AzureApiTransportTest.php b/src/Symfony/Component/Mailer/Bridge/Azure/Tests/Transport/AzureApiTransportTest.php
@@ -121,7 +121,7 @@ public function testTagAndMetadataHeaders()
     public function testItDoesNotAllowToAddResourceNameWithDot()
     {
         $this->expectException(\Exception::class);
-        $this->expectExceptionMessage('Resource name cannot contain or end with a dot');
+        $this->expectExceptionMessage('Resource name must not end with a dot "."');
 
         new AzureApiTransport('KEY', 'ACS_RESOURCE_NAME.');
     }
diff --git a/src/Symfony/Component/Mailer/Bridge/Azure/Transport/AzureApiTransport.php b/src/Symfony/Component/Mailer/Bridge/Azure/Transport/AzureApiTransport.php
@@ -43,8 +43,8 @@ public function __construct(
         ?EventDispatcherInterface $dispatcher = null,
         ?LoggerInterface $logger = null,
     ) {
-        if (str_contains($resourceName, '.') || str_ends_with($resourceName, '.')) {
-            throw new \Exception('Resource name cannot contain or end with a dot.');
+        if (str_ends_with($resourceName, '.')) {
+            throw new \Exception('Resource name must not end with a dot ".".');
         }
 
         parent::__construct($client, $dispatcher, $logger);

Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,7 @@ public function testTagAndMetadataHeaders()`
`121`	`121`	`public function testItDoesNotAllowToAddResourceNameWithDot()`
`122`	`122`	`{`
`123`	`123`	`$this->expectException(\Exception::class);`
`124`		`- $this->expectExceptionMessage('Resource name cannot contain or end with a dot');`
	`124`	`+ $this->expectExceptionMessage('Resource name must not end with a dot "."');`
`125`	`125`
`126`	`126`	`new AzureApiTransport('KEY', 'ACS_RESOURCE_NAME.');`
`127`	`127`	`}`