minor #34308 [Security] Avoid unnecessary usage of Reflection (chalasr)

chalasr · chalasr · commit d5ba53547e25 · 2019-11-09T23:27:08.000+01:00
This PR was merged into the 4.4 branch. Discussion ---------- [Security] Avoid unnecessary usage of Reflection | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Commits ------- 2377418 [Security] Avoid unnecessary usage of Reflection
diff --git a/src/Symfony/Component/Security/Core/Encoder/EncoderFactory.php b/src/Symfony/Component/Security/Core/Encoder/EncoderFactory.php
@@ -78,9 +78,7 @@ private function createEncoder(array $config, bool $isExtra = false): PasswordEn
             throw new \InvalidArgumentException(sprintf('"arguments" must be set in %s.', json_encode($config)));
         }
 
-        $reflection = new \ReflectionClass($config['class']);
-
-        $encoder = $reflection->newInstanceArgs($config['arguments']);
+        $encoder = new $config['class'](...$config['arguments']);
 
         if ($isExtra || !\in_array($config['class'], [NativePasswordEncoder::class, SodiumPasswordEncoder::class], true)) {
             return $encoder;

Original file line number	Diff line number	Diff line change
`@@ -78,9 +78,7 @@ private function createEncoder(array $config, bool $isExtra = false): PasswordEn`
`78`	`78`	`throw new \InvalidArgumentException(sprintf('"arguments" must be set in %s.', json_encode($config)));`
`79`	`79`	`}`
`80`	`80`
`81`		`- $reflection = new \ReflectionClass($config['class']);`
`82`		`-`
`83`		`- $encoder = $reflection->newInstanceArgs($config['arguments']);`
	`81`	`+ $encoder = new $config['class'](...$config['arguments']);`
`84`	`82`
`85`	`83`	`if ($isExtra \|\| !\in_array($config['class'], [NativePasswordEncoder::class, SodiumPasswordEncoder::class], true)) {`
`86`	`84`	`return $encoder;`