bug #22040 [FrameworkBundle] improve message when workflows are missing (xabbuh)

lyrixx · lyrixx · commit d50885cc166b · 2017-03-17T16:59:28.000+01:00
This PR was merged into the 3.2 branch. Discussion ---------- [FrameworkBundle] improve message when workflows are missing | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 46c12c9 improve message when workflows are missing
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
@@ -397,6 +397,10 @@ private function registerWorkflowConfiguration(array $workflows, ContainerBuilde
             return;
         }
 
+        if (!class_exists(Workflow\Workflow::class)) {
+            throw new LogicException('Workflow support cannot be enabled as the Workflow component is not installed.');
+        }
+
         $loader->load('workflow.xml');
 
         $registryDefinition = $container->getDefinition('workflow.registry');
diff --git a/src/Symfony/Bundle/FrameworkBundle/composer.json b/src/Symfony/Bundle/FrameworkBundle/composer.json
@@ -50,6 +50,7 @@
         "symfony/translation": "~3.2",
         "symfony/templating": "~2.8|~3.0",
         "symfony/validator": "~3.2",
+        "symfony/workflow": "~3.2",
         "symfony/yaml": "~3.2",
         "symfony/property-info": "~3.1",
         "doctrine/annotations": "~1.0",

Original file line number	Diff line number	Diff line change
`@@ -397,6 +397,10 @@ private function registerWorkflowConfiguration(array $workflows, ContainerBuilde`
`397`	`397`	`return;`
`398`	`398`	`}`
`399`	`399`
	`400`	`+ if (!class_exists(Workflow\Workflow::class)) {`
	`401`	`+ throw new LogicException('Workflow support cannot be enabled as the Workflow component is not installed.');`
	`402`	`+ }`
	`403`	`+`
`400`	`404`	`$loader->load('workflow.xml');`
`401`	`405`
`402`	`406`	`$registryDefinition = $container->getDefinition('workflow.registry');`