[Notifier] Change return type

OskarStark · OskarStark · commit d4f001afec98 · 2020-12-25T11:55:31.000+01:00
diff --git a/UPGRADE-5.3.md b/UPGRADE-5.3.md
@@ -23,6 +23,11 @@ HttpKernel
 
  * Marked the class `Symfony\Component\HttpKernel\EventListener\DebugHandlersListener` as internal
 
+Notifier
+-------
+
+* Changed the return type of `Symfony\Component\Notifier\Transport\AbstractTransportFactory::getEndpoint()` from `?string` to `string`
+
 PhpunitBridge
 -------------
 
diff --git a/src/Symfony/Component/Notifier/Bridge/Infobip/InfobipTransport.php b/src/Symfony/Component/Notifier/Bridge/Infobip/InfobipTransport.php
@@ -85,7 +85,7 @@ protected function doSend(MessageInterface $message): SentMessage
         return new SentMessage($message, (string) $this);
     }
 
-    protected function getEndpoint(): ?string
+    protected function getEndpoint(): string
     {
         return $this->host.($this->port ? ':'.$this->port : '');
     }
diff --git a/src/Symfony/Component/Notifier/Bridge/Mattermost/MattermostTransport.php b/src/Symfony/Component/Notifier/Bridge/Mattermost/MattermostTransport.php
@@ -85,7 +85,7 @@ protected function doSend(MessageInterface $message): SentMessage
         return $sentMessage;
     }
 
-    protected function getEndpoint(): ?string
+    protected function getEndpoint(): string
     {
         return rtrim($this->host.($this->port ? ':'.$this->port : '').($this->path ?? ''), '/');
     }
diff --git a/src/Symfony/Component/Notifier/CHANGELOG.md b/src/Symfony/Component/Notifier/CHANGELOG.md
@@ -5,6 +5,7 @@ CHANGELOG
 -----
 
  * The component is not marked as `@experimental` anymore
+* [BC BREAK] Changed the return type of `AbstractTransportFactory::getEndpoint()` from `?string` to `string`
 
 5.2.0
 -----
diff --git a/src/Symfony/Component/Notifier/Transport/AbstractTransport.php b/src/Symfony/Component/Notifier/Transport/AbstractTransport.php
@@ -79,7 +79,7 @@ public function send(MessageInterface $message): SentMessage
 
     abstract protected function doSend(MessageInterface $message): SentMessage;
 
-    protected function getEndpoint(): ?string
+    protected function getEndpoint(): string
     {
         return ($this->host ?: $this->getDefaultHost()).($this->port ? ':'.$this->port : '');
     }

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ protected function doSend(MessageInterface $message): SentMessage`
`85`	`85`	`return new SentMessage($message, (string) $this);`
`86`	`86`	`}`
`87`	`87`
`88`		`- protected function getEndpoint(): ?string`
	`88`	`+ protected function getEndpoint(): string`
`89`	`89`	`{`
`90`	`90`	`return $this->host.($this->port ? ':'.$this->port : '');`
`91`	`91`	`}`
Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ public function send(MessageInterface $message): SentMessage`
`79`	`79`
`80`	`80`	`abstract protected function doSend(MessageInterface $message): SentMessage;`
`81`	`81`
`82`		`- protected function getEndpoint(): ?string`
	`82`	`+ protected function getEndpoint(): string`
`83`	`83`	`{`
`84`	`84`	`return ($this->host ?: $this->getDefaultHost()).($this->port ? ':'.$this->port : '');`
`85`	`85`	`}`