bug #24910 [HttpKernel][Debug] Remove noise from stack frames of deprecations (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit d4d8d3a54c43 · 2017-11-10T18:58:45.000+01:00
This PR was merged into the 3.3 branch. Discussion ---------- [HttpKernel][Debug] Remove noise from stack frames of deprecations | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24625 | License | MIT | Doc PR | - Collecting arguments of deprecations is too heavy, and was unintended in fact. Commits ------- f154be3 [HttpKernel][Debug] Remove noise from stack frames of deprecations
diff --git a/src/Symfony/Component/Debug/ErrorHandler.php b/src/Symfony/Component/Debug/ErrorHandler.php
@@ -707,7 +707,7 @@ private function cleanTrace($backtrace, $type, $file, $line, $throw)
         }
         if (!($throw || $this->scopedErrors & $type)) {
             for ($i = 0; isset($lightTrace[$i]); ++$i) {
-                unset($lightTrace[$i]['args']);
+                unset($lightTrace[$i]['args'], $lightTrace[$i]['object']);
             }
         }
 
diff --git a/src/Symfony/Component/HttpKernel/EventListener/DebugHandlersListener.php b/src/Symfony/Component/HttpKernel/EventListener/DebugHandlersListener.php
@@ -86,7 +86,7 @@ public function configure(Event $event = null)
                         $handler->screamAt($levels);
                     }
                     if ($this->scope) {
-                        $handler->scopeAt($this->levels);
+                        $handler->scopeAt($levels & ~E_USER_DEPRECATED & ~E_DEPRECATED);
                     } else {
                         $handler->scopeAt(0, true);
                     }
