Edit comments

dunglas · dunglas · commit d37eeabd3aa1 · 2016-07-01T10:33:24.000+02:00
diff --git a/src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php b/src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php
@@ -187,6 +187,7 @@ private function autowireMethod($id, Definition $definition, \ReflectionMethod $
                         } elseif ($parameter->isDefaultValueAvailable()) {
                             $value = $parameter->getDefaultValue();
                         } else {
+                            // The exception code is set to 1 if the exception must be thrown even if it's a setter
                             if (1 === $e->getCode() || $isConstructor) {
                                 throw $e;
                             }
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Compiler/AutowirePassTest.php b/src/Symfony/Component/DependencyInjection/Tests/Compiler/AutowirePassTest.php
@@ -763,7 +763,6 @@ public function setBar()
     public function setNotAutowireable(NotARealClass $n)
     {
         // should not be called
-        // ???
     }
 
     public function setArgCannotAutowire($foo)

Original file line number	Diff line number	Diff line change
`@@ -187,6 +187,7 @@ private function autowireMethod($id, Definition $definition, \ReflectionMethod $`
`187`	`187`	`} elseif ($parameter->isDefaultValueAvailable()) {`
`188`	`188`	`$value = $parameter->getDefaultValue();`
`189`	`189`	`} else {`
	`190`	`+ // The exception code is set to 1 if the exception must be thrown even if it's a setter`
`190`	`191`	`if (1 === $e->getCode() \|\| $isConstructor) {`
`191`	`192`	`throw $e;`
`192`	`193`	`}`
Original file line number	Diff line number	Diff line change
`@@ -763,7 +763,6 @@ public function setBar()`
`763`	`763`	`public function setNotAutowireable(NotARealClass $n)`
`764`	`764`	`{`
`765`	`765`	`// should not be called`
`766`		`- // ???`
`767`	`766`	`}`
`768`	`767`
`769`	`768`	`public function setArgCannotAutowire($foo)`