bug #41807 [HttpClient] fix Psr18Client when allow_url_fopen=0 (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit d35c47bc7b22 · 2021-06-24T09:56:08.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient] fix Psr18Client when allow_url_fopen=0 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #41798 | License | MIT | Doc PR | - I didn't really know what `STREAM_IS_URL` was for, now I do :) Commits ------- 9745161 [HttpClient] fix Psr18Client when allow_url_fopen=0
diff --git a/src/Symfony/Component/HttpClient/Response/StreamWrapper.php b/src/Symfony/Component/HttpClient/Response/StreamWrapper.php
@@ -53,7 +53,7 @@ public static function createResource(ResponseInterface $response, HttpClientInt
             throw new \InvalidArgumentException(sprintf('Providing a client to "%s()" is required when the response doesn\'t have any "stream()" method.', __CLASS__));
         }
 
-        if (false === stream_wrapper_register('symfony', __CLASS__, \STREAM_IS_URL)) {
+        if (false === stream_wrapper_register('symfony', __CLASS__)) {
             throw new \RuntimeException(error_get_last()['message'] ?? 'Registering the "symfony" stream wrapper failed.');
         }
 

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ public static function createResource(ResponseInterface $response, HttpClientInt`
`53`	`53`	`throw new \InvalidArgumentException(sprintf('Providing a client to "%s()" is required when the response doesn\'t have any "stream()" method.', __CLASS__));`
`54`	`54`	`}`
`55`	`55`
`56`		`- if (false === stream_wrapper_register('symfony', __CLASS__, \STREAM_IS_URL)) {`
	`56`	`+ if (false === stream_wrapper_register('symfony', __CLASS__)) {`
`57`	`57`	`throw new \RuntimeException(error_get_last()['message'] ?? 'Registering the "symfony" stream wrapper failed.');`
`58`	`58`	`}`
`59`	`59`