bug #34923 [DI] Fix support for immutable setters in CallTrait (Lctrs)

nicolas-grekas · nicolas-grekas · commit d294085689d4 · 2019-12-11T13:26:30.000+01:00
This PR was merged into the 4.3 branch. Discussion ---------- [DI] Fix support for immutable setters in CallTrait | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | | License | MIT | Doc PR | N/A Commits ------- 90ace51 [DI] Add support for immutable setters in CallTrait
diff --git a/src/Symfony/Component/DependencyInjection/Loader/Configurator/Traits/CallTrait.php b/src/Symfony/Component/DependencyInjection/Loader/Configurator/Traits/CallTrait.php
@@ -18,16 +18,17 @@ trait CallTrait
     /**
      * Adds a method to call after service initialization.
      *
-     * @param string $method    The method name to call
-     * @param array  $arguments An array of arguments to pass to the method call
+     * @param string $method       The method name to call
+     * @param array  $arguments    An array of arguments to pass to the method call
+     * @param bool   $returnsClone Whether the call returns the service instance or not
      *
      * @return $this
      *
      * @throws InvalidArgumentException on empty $method param
      */
-    final public function call($method, array $arguments = [])
+    final public function call($method, array $arguments = [], $returnsClone = false)
     {
-        $this->definition->addMethodCall($method, static::processValue($arguments, true));
+        $this->definition->addMethodCall($method, static::processValue($arguments, true), $returnsClone);
 
         return $this;
     }

Original file line number	Diff line number	Diff line change
`@@ -18,16 +18,17 @@ trait CallTrait`
`18`	`18`	`/**`
`19`	`19`	`* Adds a method to call after service initialization.`
`20`	`20`	`*`
`21`		`- * @param string $method The method name to call`
`22`		`- * @param array $arguments An array of arguments to pass to the method call`
	`21`	`+ * @param string $method The method name to call`
	`22`	`+ * @param array $arguments An array of arguments to pass to the method call`
	`23`	`+ * @param bool $returnsClone Whether the call returns the service instance or not`
`23`	`24`	`*`
`24`	`25`	`* @return $this`
`25`	`26`	`*`
`26`	`27`	`* @throws InvalidArgumentException on empty $method param`
`27`	`28`	`*/`
`28`		`- final public function call($method, array $arguments = [])`
	`29`	`+ final public function call($method, array $arguments = [], $returnsClone = false)`
`29< 5EB1 /code>`	`30`	`{`
`30`		`- $this->definition->addMethodCall($method, static::processValue($arguments, true));`
	`31`	`+ $this->definition->addMethodCall($method, static::processValue($arguments, true), $returnsClone);`
`31`	`32`
`32`	`33`	`return $this;`
`33`	`34`	`}`