bug #39474 [DomCrawler] Fix null namespace issue in Crawler (prosalov)

derrabus · derrabus · commit d259c84b60d0 · 2020-12-12T00:08:45.000+01:00
This PR was merged into the 5.3-dev branch. Discussion ---------- [DomCrawler] Fix null namespace issue in Crawler | Q | A | ------------- | --- | Branch? | 5.x  | Bug fix? | yes | New feature? | no  | Deprecations? | no  | Tickets | Fix #39277  | License | MIT | Doc PR |  In this case `isset` may cause an issue if null value would be stored in `$this->namespaces` or `$this->cachedNamespaces`, but never fetched, as if condition would return false. This PR is for 5.x, because namespace caching was introduced recently (#39097). Commits ------- 7b0a183 [DomCrawler] Fix null namespace issue in Crawler
diff --git a/src/Symfony/Component/DomCrawler/Crawler.php b/src/Symfony/Component/DomCrawler/Crawler.php
@@ -1194,11 +1194,11 @@ private function createDOMXPath(\DOMDocument $document, array $prefixes = []): \
      */
     private function discoverNamespace(\DOMXPath $domxpath, string $prefix): ?string
     {
-        if (isset($this->namespaces[$prefix])) {
+        if (\array_key_exists($prefix, $this->namespaces)) {
             return $this->namespaces[$prefix];
         }
 
-        if (isset($this->cachedNamespaces[$prefix])) {
+        if ($this->cachedNamespaces->offsetExists($prefix)) {
             return $this->cachedNamespaces[$prefix];
         }
 

Original file line number	Diff line number	Diff line change
`@@ -1194,11 +1194,11 @@ private function createDOMXPath(\DOMDocument $document, array $prefixes = []): \`
`1194`	`1194`	`*/`
`1195`	`1195`	`private function discoverNamespace(\DOMXPath $domxpath, string $prefix): ?string`
`1196`	`1196`	`{`
`1197`		`- if (isset($this->namespaces[$prefix])) {`
	`1197`	`+ if (\array_key_exists($prefix, $this->namespaces)) {`
`1198`	`1198`	`return $this->namespaces[$prefix];`
`1199`	`1199`	`}`
`1200`	`1200`
`1201`		`- if (isset($this->cachedNamespaces[$prefix])) {`
	`1201`	`+ if ($this->cachedNamespaces->offsetExists($prefix)) {`
`1202`	`1202`	`return $this->cachedNamespaces[$prefix];`
`1203`	`1203`	`}`
`1204`	`1204`