[HttpFoundation] Fix file upload multiple with no files

enumag · enumag · commit d111996c75f6 · 2017-09-14T11:34:54.000+02:00
diff --git a/src/Symfony/Component/HttpFoundation/FileBag.php b/src/Symfony/Component/HttpFoundation/FileBag.php
@@ -69,7 +69,7 @@ public function add(array $files = array())
      *
      * @param array|UploadedFile $file A (multi-dimensional) array of uploaded file information
      *
-     * @return UploadedFile|UploadedFile[] A (multi-dimensional) array of UploadedFile instances
+     * @return UploadedFile[]|UploadedFile|null A (multi-dimensional) array of UploadedFile instances
      */
     protected function convertFileInformation($file)
     {
@@ -89,7 +89,7 @@ protected function convertFileInformation($file)
                     $file = new UploadedFile($file['tmp_name'], $file['name'], $file['type'], $file['size'], $file['error']);
                 }
             } else {
-                $file = array_map(array($this, 'convertFileInformation'), $file);
+                $file = array_filter(array_map(array($this, 'convertFileInformation'), $file));
             }
         }
 
diff --git a/src/Symfony/Component/HttpFoundation/Tests/FileBagTest.php b/src/Symfony/Component/HttpFoundation/Tests/FileBagTest.php
@@ -60,6 +60,19 @@ public function testShouldSetEmptyUploadedFilesToNull()
         $this->assertNull($bag->get('file'));
     }
 
+    public function testShouldRemoveEmptyUploadedFilesForMultiUpload()
+    {
+        $bag = new FileBag(array('file' => array(
+            'name' => array(''),
+            'type' => array(''),
+            'tmp_name' => array(''),
+            'error' => array(UPLOAD_ERR_NO_FILE),
+            'size' => array(0),
+        )));
+
+        $this->assertSame([], $bag->get('file'));
+    }
+
     public function testShouldConvertUploadedFilesWithPhpBug()
     {
         $tmpFile = $this->createTempFile();

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ public function add(array $files = array())`
`69`	`69`	`*`
`70`	`70`	`* @param array\|UploadedFile $file A (multi-dimensional) array of uploaded file information`
`71`	`71`	`*`
`72`		`- * @return UploadedFile\|UploadedFile[] A (multi-dimensional) array of UploadedFile instances`
	`72`	`+ * @return UploadedFile[]\|UploadedFile\|null A (multi-dimensional) array of UploadedFile instances`
`73`	`73`	`*/`
`74`	`74`	`protected function convertFileInformation($file)`
`75`	`75`	`{`
`@@ -89,7 +89,7 @@ protected function convertFileInformation($file)`
`89`	`89`	`$file = new UploadedFile($file['tmp_name'], $file['name'], $file['type'], $file['size'], $file['error']);`
`90`	`90`	`}`
`91`	`91`	`} else {`
`92`		`- $file = array_map(array($this, 'convertFileInformation'), $file);`
	`92`	`+ $file = array_filter(array_map(array($this, 'convertFileInformation'), $file));`
`93`	`93`	`}`
`94`	`94`	`}`
`95`	`95`