[Console] replace method by const

nicolas-grekas · nicolas-grekas · commit d0f6b98aa104 · 2021-11-02T14:48:32.000+01:00
diff --git a/src/Symfony/Component/Uid/Command/GenerateUlidCommand.php b/src/Symfony/Component/Uid/Command/GenerateUlidCommand.php
@@ -23,6 +23,12 @@
 
 class GenerateUlidCommand extends Command
 {
+    private const FORMAT_OPTIONS = [
+        'base32',
+        'base58',
+        'rfc4122',
+    ];
+
     protected static $defaultName = 'ulid:generate';
     protected static $defaultDescription = 'Generate a ULID';
 
@@ -87,7 +93,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         $formatOption = $input->getOption('format');
 
-        if (\in_array($formatOption, $this->getAvailableFormatOptions())) {
+        if (\in_array($formatOption, self::FORMAT_OPTIONS)) {
             $format = 'to'.ucfirst($formatOption);
         } else {
             $io->error(sprintf('Invalid format "%s", did you mean "base32", "base58" or "rfc4122"?', $input->getOption('format')));
@@ -112,16 +118,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
     public function complete(CompletionInput $input, CompletionSuggestions $suggestions): void
     {
         if ($input->mustSuggestOptionValuesFor('format')) {
-            $suggestions->suggestValues($this->getAvailableFormatOptions());
+            $suggestions->suggestValues(self::FORMAT_OPTIONS);
         }
     }
-
-    private function getAvailableFormatOptions(): array
-    {
-        return [
-            'base32',
-            'base58',
-            'rfc4122',
-        ];
-    }
 }
