Return int if scale = 0

VincentLanglet · VincentLanglet · commit d07e3c9be7c3 · 2020-02-22T14:33:06.000+01:00
diff --git a/src/Symfony/Component/Form/Extension/Core/DataTransformer/PercentToLocalizedStringTransformer.php b/src/Symfony/Component/Form/Extension/Core/DataTransformer/PercentToLocalizedStringTransformer.php
@@ -284,7 +284,7 @@ private function round($number)
                     break;
             }
 
-            $number /= $roundingCoef;
+            $number /= 1 === $roundingCoef ? (int) $number : $number / $roundingCoef;
         }
 
         return $number;
diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/PercentToLocalizedStringTransformerTest.php b/src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/PercentToLocalizedStringTransformerTest.php
@@ -179,7 +179,7 @@ public function testReverseTransformWithRounding($type, $scale, $input, $output,
     {
         $transformer = new PercentToLocalizedStringTransformer($scale, $type, $roundingMode);
 
-        $this->assertEquals($output, $transformer->reverseTransform($input));
+        $this->assertSame($output, $transformer->reverseTransform($input));
     }
 
     public function testReverseTransformEmpty()

Original file line number	Diff line number	Diff line change
`@@ -284,7 +284,7 @@ private function round($number)`
`284`	`284`	`break;`
`285`	`285`	`}`
`286`	`286`
`287`		`- $number /= $roundingCoef;`
	`287`	`+ $number /= 1 === $roundingCoef ? (int) $number : $number / $roundingCoef;`
`288`	`288`	`}`
`289`	`289`
`290`	`290`	`return $number;`
Original file line number	Diff line number	Diff line change
`@@ -179,7 +179,7 @@ public function testReverseTransformWithRounding($type, $scale, $input, $output,`
`179`	`179`	`{`
`180`	`180`	`$transformer = new PercentToLocalizedStringTransformer($scale, $type, $roundingMode);`
`181`	`181`
`182`		`- $this->assertEquals($output, $transformer->reverseTransform($input));`
	`182`	`+ $this->assertSame($output, $transformer->reverseTransform($input));`
`183`	`183`	`}`
`184`	`184`
`185`	`185`	`public function testReverseTransformEmpty()`