feature: take nicolas comment in account

Amrouche Hamza · Amrouche Hamza · commit cff1c8edd1ab · 2019-04-06T14:38:26.000+02:00
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/DebugAutowiringCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/DebugAutowiringCommand.php
@@ -126,7 +126,10 @@ protected function execute(InputInterface $input, OutputInterface $output)
                 if ($serviceAlias->isDeprecated()) {
                     $serviceLine .= ' - <fg=magenta>deprecated</>';
                 }
-            } elseif (!$all && !$search) {
+            } elseif (!$all) {
+                if ($search) {
+                    $io->text('Non-aliased services are not shown unless the "--all" option is passed, you would better not type-hint on these classes.');
+                }
                 continue;
             }
             $text[] = $serviceLine;
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/DebugAutowiringCommandTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/DebugAutowiringCommandTest.php
@@ -83,7 +83,7 @@ public function testSearchNotAliasedService()
         $tester = new ApplicationTester($application);
         $tester->run(['command' => 'debug:autowiring', 'search' => 'redirect']);
 
-        $this->assertContains('Symfony\Bundle\FrameworkBundle\Controller\RedirectController', $tester->getDisplay());
+        $this->assertContains('The non-aliased services are not shown unless the all option is passed, please do not type-hint the classes if possible.', $tester->getDisplay());
         $this->assertNotContains('Symfony\Component\Routing\RouterInterface', $tester->getDisplay());
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,10 @@ protected function execute(InputInterface $input, OutputInterface $output)`
`126`	`126`	`if ($serviceAlias->isDeprecated()) {`
`127`	`127`	`$serviceLine .= ' - <fg=magenta>deprecated</>';`
`128`	`128`	`}`
`129`		`- } elseif (!$all && !$search) {`
	`129`	`+ } elseif (!$all) {`
	`130`	`+ if ($search) {`
	`131`	`+ $io->text('Non-aliased services are not shown unless the "--all" option is passed, you would better not type-hint on these classes.');`
	`132`	`+ }`
`130`	`133`	`continue;`
`131`	`134`	`}`
`132`	`135`	`$text[] = $serviceLine;`
Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ public function testSearchNotAliasedService()`
`83`	`83`	`$tester = new ApplicationTester($application);`
`84`	`84`	`$tester->run(['command' => 'debug:autowiring', 'search' => 'redirect']);`
`85`	`85`
`86`		`- $this->assertContains('Symfony\Bundle\FrameworkBundle\Controller\RedirectController', $tester->getDisplay());`
	`86`	`+ $this->assertContains('The non-aliased services are not shown unless the all option is passed, please do not type-hint the classes if possible.', $tester->getDisplay());`
`87`	`87`	`$this->assertNotContains('Symfony\Component\Routing\RouterInterface', $tester->getDisplay());`
`88`	`88`	`}`
`89`	`89`	`}`