[DoctrineBridge] deprecate MergeDoctrineCollectionListener::onBind()

HeahDude · HeahDude · commit cfb2f6c5b843 · 2016-03-09T07:02:13.000+01:00
diff --git a/src/Symfony/Bridge/Doctrine/Form/EventListener/MergeDoctrineCollectionListener.php b/src/Symfony/Bridge/Doctrine/Form/EventListener/MergeDoctrineCollectionListener.php
@@ -31,10 +31,10 @@ public static function getSubscribedEvents()
     {
         // Higher priority than core MergeCollectionListener so that this one
         // is called before
-        return array(FormEvents::SUBMIT => array('onBind', 10));
+        return array(FormEvents::SUBMIT => array('onSubmit', 10));
     }
 
-    public function onBind(FormEvent $event)
+    public function onSubmit(FormEvent $event)
     {
         $collection = $event->getForm()->getData();
         $data = $event->getData();
@@ -45,4 +45,17 @@ public function onBind(FormEvent $event)
             $collection->clear();
         }
     }
+
+    /**
+     * Alias of {@link onSubmit()}.
+     *
+     * @deprecated since version 3.1, to be removed in 4.0.
+     *             Use {@link onSubmit()} instead.
+     */
+    public function onBind(FormEvent $event)
+    {
+        @trigger_error('The '.__METHOD__.' method is deprecated since version 3.1 and will be removed in 4.0. Use the onSubmit() method instead.', E_USER_DEPRECATED);
+
+        $this->onSubmit($event);
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -31,10 +31,10 @@ public static function getSubscribedEvents()`
`31`	`31`	`{`
`32`	`32`	`// Higher priority than core MergeCollectionListener so that this one`
`33`	`33`	`// is called before`
`34`		`- return array(FormEvents::SUBMIT => array('onBind', 10));`
	`34`	`+ return array(FormEvents::SUBMIT => array('onSubmit', 10));`
`35`	`35`	`}`
`36`	`36`
`37`		`- public function onBind(FormEvent $event)`
	`37`	`+ public function onSubmit(FormEvent $event)`
`38`	`38`	`{`
`39`	`39`	`$collection = $event->getForm()->getData();`
`40`	`40`	`$data = $event->getData();`
`@@ -45,4 +45,17 @@ public function onBind(FormEvent $event)`
`45`	`45`	`$collection->clear();`
`46`	`46`	`}`
`47`	`47`	`}`
	`48`	`+`
	`49`	`+ /**`
	`50`	`+ * Alias of {@link onSubmit()}.`
	`51`	`+ *`
	`52`	`+ * @deprecated since version 3.1, to be removed in 4.0.`
	`53`	`+ * Use {@link onSubmit()} instead.`
	`54`	`+ */`
	`55`	`+ public function onBind(FormEvent $event)`
	`56`	`+ {`
	`57`	`+ @trigger_error('The '.__METHOD__.' method is deprecated since version 3.1 and will be removed in 4.0. Use the onSubmit() method instead.', E_USER_DEPRECATED);`
	`58`	`+`
	`59`	`+ $this->onSubmit($event);`
	`60`	`+ }`
`48`	`61`	`}`