override options recursively

yceruto · yceruto · commit cf95089335b5 · 2017-05-28T21:27:43.000-04:00
diff --git a/src/Symfony/Component/Form/FormFactory.php b/src/Symfony/Component/Form/FormFactory.php
@@ -126,7 +126,7 @@ public function createBuilderForProperty($class, $property, $data = null, array
 
         // user options may override guessed options
         if ($typeGuess) {
-            $options = array_merge($typeGuess->getOptions(), $options);
+            $options = array_replace_recursive($typeGuess->getOptions(), $options);
         }
 
         return $this->createNamedBuilder($property, $type, $data, $options);
diff --git a/src/Symfony/Component/Form/Tests/FormFactoryTest.php b/src/Symfony/Component/Form/Tests/FormFactoryTest.php
@@ -450,15 +450,15 @@ public function testOptionsCanBeOverridden()
                 ->with('Application\Author', 'firstName')
                 ->will($this->returnValue(new TypeGuess(
                     'text',
-                    array('attr' => array('maxlength' => 10)),
+                    array('attr' => array('class' => 'foo', 'maxlength' => 10)),
                     Guess::MEDIUM_CONFIDENCE
                 )));
 
         $factory = $this->getMockFactory(array('createNamedBuilder'));
 
         $factory->expects($this->once())
             ->method('createNamedBuilder')
-            ->with('firstName', 'text', null, array('attr' => array('maxlength' => 11)))
+            ->with('firstName', 'text', null, array('attr' => array('class' => 'foo', 'maxlength' => 11)))
             ->will($this->returnValue('builderInstance'));
 
         $this->builder = $factory->createBuilderForProperty(

Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,7 @@ public function createBuilderForProperty($class, $property, $data = null, array`
`126`	`126`
`127`	`127`	`// user options may override guessed options`
`128`	`128`	`if ($typeGuess) {`
`129`		`- $options = array_merge($typeGuess->getOptions(), $options);`
	`129`	`+ $options = array_replace_recursive($typeGuess->getOptions(), $options);`
`130`	`130`	`}`
`131`	`131`
`132`	`132`	`return $this->createNamedBuilder($property, $type, $data, $options);`