bug #30274 [VarDumper] fix serializing Stub instances (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit ce7afc222d7c · 2019-02-17T10:38:12.000+01:00
This PR was merged into the 3.4 branch. Discussion ---------- [VarDumper] fix serializing Stub instances | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - There are more properties in child classes, and we can skip serializing properties that are set to their default values. Commits ------- 46d6a4d [VarDumper] fix serializing Stub instances
diff --git a/src/Symfony/Component/VarDumper/Cloner/Stub.php b/src/Symfony/Component/VarDumper/Cloner/Stub.php
@@ -39,22 +39,29 @@ class Stub
     public $position = 0;
     public $attr = [];
 
+    private static $defaultProperties = [];
+
     /**
      * @internal
      */
     public function __sleep()
     {
-        $this->serialized = [$this->class, $this->position, $this->cut, $this->type, $this->value, $this->handle, $this->refCount, $this->attr];
+        $properties = [];
 
-        return ['serialized'];
-    }
+        if (!isset(self::$defaultProperties[$c = \get_class($this)])) {
+            self::$defaultProperties[$c] = get_class_vars($c);
 
-    /**
-     * @internal
-     */
-    public function __wakeup()
-    {
-        list($this->class, $this->position, $this->cut, $this->type, $this->value, $this->handle, $this->refCount, $this->attr) = $this->serialized;
-        unset($this->serialized);
+            foreach ((new \ReflectionClass($c))->getStaticProperties() as $k => $v) {
+                unset(self::$defaultProperties[$c][$k]);
+            }
+        }
+
+        foreach (self::$defaultProperties[$c] as $k => $v) {
+            if ($this->$k !== $v) {
+                $properties[] = $k;
+            }
+        }
+
+        return $properties;
     }
 }
