symfony
diff --git a/‎src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/AddConsoleCommandPass.php‎
Lines changed: 4 additions & 6 deletions b/‎src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/AddConsoleCommandPass.php‎
Lines changed: 4 additions & 6 deletions
diff --git a/‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Compiler/AddConsoleCommandPassTest.php‎
Lines changed: 1 addition & 18 deletions b/‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Compiler/AddConsoleCommandPassTest.php‎
Lines changed: 1 addition & 18 deletions
@@ -24,14 +24,11 @@ class AddConsoleCommandPass implements CompilerPassInterface
     public function process(ContainerBuilder $container)
     {
         $commandServices = $container->findTaggedServiceIds('console.command');
+        $serviceIds = array();
 
         foreach ($commandServices as $id => $tags) {
             $definition = $container->getDefinition($id);
 
-            if (!$definition->isPublic()) {
-                throw new \InvalidArgumentException(sprintf('The service "%s" tagged "console.command" must be public.', $id));
-            }
-
             if ($definition->isAbstract()) {
                 throw new \InvalidArgumentException(sprintf('The service "%s" tagged "console.command" must not be abstract.', $id));
             }
@@ -40,9 +37,10 @@ public function process(ContainerBuilder $container)
             if (!is_subclass_of($class, 'Symfony\\Component\\Console\\Command\\Command')) {
                 throw new \InvalidArgumentException(sprintf('The service "%s" tagged "console.command" must be a subclass of "Symfony\\Component\\Console\\Command\\Command".', $id));
             }
-            $container->setAlias('console.command.'.strtolower(str_replace('\\', '_', $class)), $id);
+            $container->setAlias($serviceId = 'console.command.'.strtolower(str_replace('\\', '_', $class)), $id);
+            $serviceIds[] = $serviceId;
         }
 
-        $container->setParameter('console.command.ids', array_keys($commandServices));
+        $container->setParameter('console.command.ids', $serviceIds);
     }
 }
@@ -36,24 +36,7 @@ public function testProcess()
         $this->assertSame('my-command', (string) $container->getAlias($alias));
 
         $this->assertTrue($container->hasParameter('console.command.ids'));
-        $this->assertSame(array('my-command'), $container->getParameter('console.command.ids'));
-    }
-
-    /**
-     * @expectedException \InvalidArgumentException
-     * @expectedExceptionMessage The service "my-command" tagged "console.command" must be public.
-     */
-    public function testProcessThrowAnExceptionIfTheServiceIsNotPublic()
-    {
-        $container = new ContainerBuilder();
-        $container->addCompilerPass(new AddConsoleCommandPass());
-
-        $definition = new Definition('Symfony\Bundle\FrameworkBundle\Tests\DependencyInjection\Compiler\MyCommand');
-        $definition->addTag('console.command');
-        $definition->setPublic(false);
-        $container->setDefinition('my-command', $definition);
-
-        $container->compile();
+        $this->assertSame(array('console.command.symfony_bundle_frameworkbundle_tests_dependencyinjection_compiler_mycommand'), $container->getParameter('console.command.ids'));
     }
 
     /**
Original file line number	Diff line number	Diff line change
`@@ -24,14 +24,11 @@ class AddConsoleCommandPass implements CompilerPassInterface`
`24`	`24`	`public function process(ContainerBuilder $container)`
`25`	`25`	`{`
`26`	`26`	`$commandServices = $container->findTaggedServiceIds('console.command');`
	`27`	`+ $serviceIds = array();`
`27`	`28`
`28`	`29`	`foreach ($commandServices as $id => $tags) {`
`29`	`30`	`$definition = $container->getDefinition($id);`
`30`	`31`
`31`		`- if (!$definition->isPublic()) {`
`32`		`- throw new \InvalidArgumentException(sprintf('The service "%s" tagged "console.command" must be public.', $id));`
`33`		`- }`
`34`		`-`
`35`	`32`	`if ($definition->isAbstract()) {`
`36`	`33`	`throw new \InvalidArgumentException(sprintf('The service "%s" tagged "console.command" must not be abstract.', $id));`
`37`	`34`	`}`
`@@ -40,9 +37,10 @@ public function process(ContainerBuilder $container)`
`40`	`37`	`if (!is_subclass_of($class, 'Symfony\\Component\\Console\\Command\\Command')) {`
`41`	`38`	`throw new \InvalidArgumentException(sprintf('The service "%s" tagged "console.command" must be a subclass of "Symfony\\Component\\Console\\Command\\Command".', $id));`
`42`	`39`	`}`
`43`		`- $container->setAlias('console.command.'.strtolower(str_replace('\\', '_', $class)), $id);`
	`40`	`+ $container->setAlias($serviceId = 'console.command.'.strtolower(str_replace('\\', '_', $class)), $id);`
	`41`	`+ $serviceIds[] = $serviceId;`
`44`	`42`	`}`
`45`	`43`
`46`		`- $container->setParameter('console.command.ids', array_keys($commandServices));`
	`44`	`+ $container->setParameter('console.command.ids', $serviceIds);`
`47`	`45`	`}`
`48`	`46`	`}`