[Bridge] Fix mkdir() race condition in ProxyCacheWarmer

andrey-tech · andrey-tech · commit cdb6c15618a0 · 2022-09-06T14:08:20.000+03:00
diff --git a/src/Symfony/Bridge/Doctrine/CacheWarmer/ProxyCacheWarmer.php b/src/Symfony/Bridge/Doctrine/CacheWarmer/ProxyCacheWarmer.php
@@ -49,7 +49,7 @@ public function warmUp($cacheDir)
         foreach ($this->registry->getManagers() as $em) {
             // we need the directory no matter the proxy cache generation strategy
             if (!is_dir($proxyCacheDir = $em->getConfiguration()->getProxyDir())) {
-                if (false === @mkdir($proxyCacheDir, 0777, true)) {
+                if (false === @mkdir($proxyCacheDir, 0777, true) && !is_dir($proxyCacheDir)) {
                     throw new \RuntimeException(sprintf('Unable to create the Doctrine Proxy directory "%s".', $proxyCacheDir));
                 }
             } elseif (!is_writable($proxyCacheDir)) {

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ public function warmUp($cacheDir)`
`49`	`49`	`foreach ($this->registry->getManagers() as $em) {`
`50`	`50`	`// we need the directory no matter the proxy cache generation strategy`
`51`	`51`	`if (!is_dir($proxyCacheDir = $em->getConfiguration()->getProxyDir())) {`
`52`		`- if (false === @mkdir($proxyCacheDir, 0777, true)) {`
	`52`	`+ if (false === @mkdir($proxyCacheDir, 0777, true) && !is_dir($proxyCacheDir)) {`
`53`	`53`	`throw new \RuntimeException(sprintf('Unable to create the Doctrine Proxy directory "%s".', $proxyCacheDir));`
`54`	`54`	`}`
`55`	`55`	`} elseif (!is_writable($proxyCacheDir)) {`