feature #51793 [FrameworkBundle] Change BrowserKitAssertionsTrait::getClient() to be protected (fabpot)

fabpot · fabpot · commit cd53ccd80c4c · 2023-10-01T09:17:50.000+02:00
This PR was merged into the 6.4 branch. Discussion ---------- [FrameworkBundle] Change BrowserKitAssertionsTrait::getClient() to be protected | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | yes  | Deprecations? | no  | Tickets | Fix #40817 | License | MIT Make `BrowserKitAssertionsTrait::getClient()` protected (see ticket for use cases). As `getRequest()` and `getResponse()` can easily be retrieved from `getClient()`, they are still private. Commits ------- 7f98fa1 [FrameworkBundle] Change BrowserKitAssertionsTrait::getClient() to be protected
diff --git a/src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md b/src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md
@@ -26,6 +26,7 @@ CHANGELOG
  * Deprecate `framework.serializer.enable_annotations`, use `framework.serializer.enable_attributes` instead
  * Add `array $tokenAttributes = []` optional parameter to `KernelBrowser::loginUser()`
  * Add support for relative URLs in BrowserKit's redirect assertion.
+ * Change BrowserKitAssertionsTrait::getClient() to be protected
 
 6.3
 ---
diff --git a/src/Symfony/Bundle/FrameworkBundle/Test/BrowserKitAssertionsTrait.php b/src/Symfony/Bundle/FrameworkBundle/Test/BrowserKitAssertionsTrait.php
@@ -162,7 +162,7 @@ public static function assertThatForClient(Constraint $constraint, string $messa
         self::assertThat(self::getClient(), $constraint, $message);
     }
 
-    private static function getClient(AbstractBrowser $newClient = null): ?AbstractBrowser
+    protected static function getClient(AbstractBrowser $newClient = null): ?AbstractBrowser
     {
         static $client;
 

Original file line number	Diff line number	Diff line change
`@@ -162,7 +162,7 @@ public static function assertThatForClient(Constraint $constraint, string $messa`
`162`	`162`	`self::assertThat(self::getClient(), $constraint, $message);`
`163`	`163`	`}`
`164`	`164`
`165`		`- private static function getClient(AbstractBrowser $newClient = null): ?AbstractBrowser`
	`165`	`+ protected static function getClient(AbstractBrowser $newClient = null): ?AbstractBrowser`
`166`	`166`	`{`
`167`	`167`	`static $client;`
`168`	`168`