bug #20714 [FrameworkBundle] Fix unresolved parameters from default configs in debug:config (chalasr)

fabpot · fabpot · commit cd0bb3d52823 · 2016-12-13T08:41:32.000+01:00
This PR was merged into the 2.7 branch. Discussion ---------- [FrameworkBundle] Fix unresolved parameters from default configs in debug:config | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a When using the `debug:config` command, if the dumped configuration is explicitly defined by the user, then parameters are properly resolved in the output. If it is not, and values come from the bundle default configuration directly, they are not. Steps to reproduce: - Checkout the symfony demo - Run `debug:config twig` - Look at the `debug` key, it is the `kernel.debug` parameter properly resolved: `true` - Look at the `cache` key, it is not resolved: `'%kernel.cache_dir%/twig'` This fixes it by resolving the configs once again after processing the configuration. ping @weaverryan Commits ------- 26f588a Fix unresolved parameters from default bundle configs in debug:config
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/ConfigDebugCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/ConfigDebugCommand.php
@@ -90,7 +90,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
             $output->writeln(sprintf('# Current configuration for "%s"', $name));
         }
 
-        $output->writeln(Yaml::dump(array($extension->getAlias() => $config), 10));
+        $output->writeln(Yaml::dump(array($extension->getAlias() => $container->getParameterBag()->resolveValue($config)), 10));
     }
 
     private function compileContainer()

Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,7 @@ protected function execute(InputInterface $input, OutputInterface $output)`
`90`	`90`	`$output->writeln(sprintf('# Current configuration for "%s"', $name));`
`91`	`91`	`}`
`92`	`92`
`93`		`- $output->writeln(Yaml::dump(array($extension->getAlias() => $config), 10));`
	`93`	`+ $output->writeln(Yaml::dump(array($extension->getAlias() => $container->getParameterBag()->resolveValue($config)), 10));`
`94`	`94`	`}`
`95`	`95`
`96`	`96`	`private function compileContainer()`