fix color detection

xabbuh · xabbuh · commit ccea2e10cffa · 2024-02-08T08:32:00.000+01:00
diff --git a/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler.php b/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler.php
@@ -404,7 +404,7 @@ private static function hasColorSupport()
         }
 
         if (!self::isTty()) {
-            return true;
+            return false;
         }
 
         if ('\\' === \DIRECTORY_SEPARATOR
diff --git a/src/Symfony/Component/VarDumper/Dumper/CliDumper.php b/src/Symfony/Component/VarDumper/Dumper/CliDumper.php
@@ -612,8 +612,12 @@ private function hasColorSupport($stream): bool
 
         // Detect msysgit/mingw and assume this is a tty because detection
         // does not work correctly, see https://github.com/composer/composer/issues/9690
-        if (!@stream_isatty($stream) && !\in_array(strtoupper((string) getenv('MSYSTEM')), ['MINGW32', 'MINGW64'], true)) {
-            return true;
+        if (!\in_array(strtoupper((string) getenv('MSYSTEM')), ['MINGW32', 'MINGW64'], true)) {
+            return false;
+        }
+
+        if (!@stream_isatty(\STDOUT)) {
+            return false;
         }
 
         if ('\\' === \DIRECTORY_SEPARATOR && @sapi_windows_vt100_support($stream)) {

Original file line number	Diff line number	Diff line change
`@@ -404,7 +404,7 @@ private static function hasColorSupport()`
`404`	`404`	`}`
`405`	`405`
`406`	`406`	`if (!self::isTty()) {`
`407`		`- return true;`
	`407`	`+ return false;`
`408`	`408`	`}`
`409`	`409`
`410`	`410`	`if ('\\' === \DIRECTORY_SEPARATOR`