bug #27365 [Serializer] Check the value of enable_max_depth if defined (dunglas)

nicolas-grekas · nicolas-grekas · commit cb106fa2ff99 · 2018-05-25T16:39:07.000+02:00
This PR was merged into the 3.4 branch. Discussion ---------- [Serializer] Check the value of enable_max_depth if defined | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no  | BC breaks? | no  | Deprecations? | no  | Tests pass? | yes  | Fixed tickets | n/a  | License | MIT | Doc PR | n/a Because it confuses some users that `['enable_max_depth' => false]` actually triggers the check. Commits ------- e88e0f3 [Serializer] Check the value of enable_max_depth if defined
diff --git a/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
@@ -331,6 +331,7 @@ private function isMaxDepthReached(array $attributesMetadata, $class, $attribute
     {
         if (
             !isset($context[static::ENABLE_MAX_DEPTH]) ||
+            !$context[static::ENABLE_MAX_DEPTH] ||
             !isset($attributesMetadata[$attribute]) ||
             null === $maxDepth = $attributesMetadata[$attribute]->getMaxDepth()
         ) {

Original file line number	Diff line number	Diff line change
`@@ -331,6 +331,7 @@ private function isMaxDepthReached(array $attributesMetadata, $class, $attribute`
`331`	`331`	`{`
`332`	`332`	`if (`
`333`	`333`	`!isset($context[static::ENABLE_MAX_DEPTH]) \|\|`
	`334`	`+ !$context[static::ENABLE_MAX_DEPTH] \|\|`
`334`	`335`	`!isset($attributesMetadata[$attribute]) \|\|`
`335`	`336`	`null === $maxDepth = $attributesMetadata[$attribute]->getMaxDepth()`
`336`	`337`	`) {`