add phpdoc and check aliases array content in setter

damienfern · damienfern · commit cae7ff1b8a12 · 2025-01-13T17:34:24.000+01:00
diff --git a/src/Symfony/Component/Routing/Attribute/Route.php b/src/Symfony/Component/Routing/Attribute/Route.php
@@ -11,6 +11,8 @@
 
 namespace Symfony\Component\Routing\Attribute;
 
+use Symfony\Component\Routing\Exception\InvalidArgumentException;
+
 /**
  * @author Fabien Potencier <fabien@symfony.com>
  * @author Alexander M. Turek <me@derrabus.de>
@@ -67,14 +69,6 @@ public function __construct(
         }
         $this->setMethods($methods);
         $this->setSchemes($schemes);
-
-        if (\is_array($alias)) {
-            foreach ($alias as $a) {
-                if (!\is_string($a)) {
-                    throw new \TypeError(\sprintf('The "alias" argument of the Route attribute must be a string or an array of strings, but got "%s".', \get_debug_type($a)));
-                }
-            }
-        }
         $this->setAliases($alias);
 
         if (null !== $locale) {
@@ -219,8 +213,20 @@ public function getAliases(): array
         return $this->aliases;
     }
 
+    /**
+     * @param list<string>|string $aliases
+     *
+     * @throws InvalidArgumentException if the "alias" argument is not a string or an array of strings
+     */
     public function setAliases(array|string $aliases): void
     {
+        if (\is_array($aliases)) {
+            foreach ($aliases as $a) {
+                if (!\is_string($a)) {
+                    throw new InvalidArgumentException(\sprintf('The "alias" argument of the Route attribute must be a string or an array of strings. Got "%s".', \get_debug_type($a)));
+                }
+            }
+        }
         $this->aliases = (array) $aliases;
     }
 }
diff --git a/src/Symfony/Component/Routing/Tests/Attribute/RouteTest.php b/src/Symfony/Component/Routing/Tests/Attribute/RouteTest.php
@@ -13,6 +13,7 @@
 
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Routing\Attribute\Route;
+use Symfony\Component\Routing\Exception\InvalidArgumentException;
 use Symfony\Component\Routing\Tests\Fixtures\AttributeFixtures\FooController;
 
 class RouteTest extends TestCase
@@ -29,8 +30,8 @@ public function testLoadFromAttribute(string $methodName, string $getter, mixed
 
     public function testAliasIsAnArrayOfString()
     {
-        $this->expectException(\TypeError::class);
-        $this->expectExceptionMessage('The "alias" argument of the Route attribute must be a string or an array of strings, but got stdClass.');
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('The "alias" argument of the Route attribute must be a string or an array of strings. Got "stdClass".');
 
         new Route('/hello', alias: ['alias', new \stdClass()]);
     }

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,7 @@`
`13`	`13`
`14`	`14`	`use PHPUnit\Framework\TestCase;`
`15`	`15`	`use Symfony\Component\Routing\Attribute\Route;`
	`16`	`+use Symfony\Component\Routing\Exception\InvalidArgumentException;`
`16`	`17`	`use Symfony\Component\Routing\Tests\Fixtures\AttributeFixtures\FooController;`
`17`	`18`
`18`	`19`	`class RouteTest extends TestCase`
`@@ -29,8 +30,8 @@ public function testLoadFromAttribute(string $methodName, string $getter, mixed`
`29`	`30`
`30`	`31`	`public function testAliasIsAnArrayOfString()`
`31`	`32`	`{`
`32`		`- $this->expectException(\TypeError::class);`
`33`		`- $this->expectExceptionMessage('The "alias" argument of the Route attribute must be a string or an array of strings, but got stdClass.');`
	`33`	`+ $this->expectException(InvalidArgumentException::class);`
	`34`	`+ $this->expectExceptionMessage('The "alias" argument of the Route attribute must be a string or an array of strings. Got "stdClass".');`
`34`	`35`
`35`	`36`	`new Route('/hello', alias: ['alias', new \stdClass()]);`
`36`	`37`	`}`