Doc fix: clarify isMethodCacheable() returns true only for GET & HEAD

tamc · web-flow · commit cadd5cda37c3 · 2018-11-23T15:43:18.000Z
The current documentation points to https://tools.ietf.org/html/rfc7231#section-4.2.3. The spec says: "this specification defines GET, HEAD, and POST as cacheable, although the overwhelming majority of cache implementations only support GET and HEAD.". This fix to the documentation clarifies that Symfony follows majority (excluding POST) rather than the spec (including POST).
diff --git a/src/Symfony/Component/HttpFoundation/Request.php b/src/Symfony/Component/HttpFoundation/Request.php
@@ -1471,7 +1471,7 @@ public function isMethodSafe(/* $andCacheable = true */)
     }
 
     /**
-     * Checks whether the method is cacheable or not.
+     * Checks whether the method is cacheable or not. Returns true for GET and HEAD, false otherwise.
      *
      * @see https://tools.ietf.org/html/rfc7231#section-4.2.3
      *

Original file line number	Diff line number	Diff line change
`@@ -1471,7 +1471,7 @@ public function isMethodSafe(/* $andCacheable = true */)`
`1471`	`1471`	`}`
`1472`	`1472`
`1473`	`1473`	`/**`
`1474`		`- * Checks whether the method is cacheable or not.`
	`1474`	`+ * Checks whether the method is cacheable or not. Returns true for GET and HEAD, false otherwise.`
`1475`	`1475`	`*`
`1476`	`1476`	`* @see https://tools.ietf.org/html/rfc7231#section-4.2.3`
`1477`	`1477`	`*`