bug #36017 [HttpKernel] Fix support for single-colon syntax for controllers (nicolas-grekas)

fabpot · fabpot · commit ca41e35d3900 · 2020-03-11T08:44:41.000+01:00
This PR was merged into the 5.0 branch. Discussion ---------- [HttpKernel] Fix support for single-colon syntax for controllers | Q | A | ------------- | --- | Branch? | master for features / 3.4, 4.4 or 5.0 for bug fixes  | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #35983 | License | MIT | Doc PR | - This reverts commit 6bb6473, reversing changes made to 4cce23d. As spotted by @stof in #35983 (comment) Commits ------- fbea81c Revert "minor #35559 [FrameworkBundle] remove mention of the old Controller class (nicolas-grekas)"
diff --git a/src/Symfony/Component/HttpKernel/DependencyInjection/RemoveEmptyControllerArgumentLocatorsPass.php b/src/Symfony/Component/HttpKernel/DependencyInjection/RemoveEmptyControllerArgumentLocatorsPass.php
@@ -51,6 +51,9 @@ public function process(ContainerBuilder $container)
                     }
                 }
                 if (!$reason) {
+                    // see Symfony\Component\HttpKernel\Controller\ContainerControllerResolver
+                    $controllers[$id.':'.$action] = $argumentRef;
+
                     if ('__invoke' === $action) {
                         $controllers[$id] = $argumentRef;
                     }
diff --git a/src/Symfony/Component/HttpKernel/Tests/DependencyInjection/RemoveEmptyControllerArgumentLocatorsPassTest.php b/src/Symfony/Component/HttpKernel/Tests/DependencyInjection/RemoveEmptyControllerArgumentLocatorsPassTest.php
@@ -49,7 +49,7 @@ public function testProcess()
 
         $controllers = $container->getDefinition((string) $resolver->getArgument(0))->getArgument(0);
 
-        $this->assertSame(['c1::fooAction'], array_keys($controllers));
+        $this->assertSame(['c1::fooAction', 'c1:fooAction'], array_keys($controllers));
         $this->assertSame(['bar'], array_keys($container->getDefinition((string) $controllers['c1::fooAction']->getValues()[0])->getArgument(0)));
 
         $expectedLog = [
@@ -73,7 +73,7 @@ public function testInvoke()
         (new RemoveEmptyControllerArgumentLocatorsPass())->process($container);
 
         $this->assertEquals(
-            ['invokable::__invoke', 'invokable'],
+            ['invokable::__invoke', 'invokable:__invoke', 'invokable'],
             array_keys($container->getDefinition((string) $resolver->getArgument(0))->getArgument(0))
         );
     }

Original file line number	Diff line number	Diff line change
`@@ -51,6 +51,9 @@ public function process(ContainerBuilder $container)`
`51`	`51`	`}`
`52`	`52`	`}`
`53`	`53`	`if (!$reason) {`
	`54`	`+ // see Symfony\Component\HttpKernel\Controller\ContainerControllerResolver`
	`55`	`+ $controllers[$id.':'.$action] = $argumentRef;`
	`56`	`+`
`54`	`57`	`if ('__invoke' === $action) {`
`55`	`58`	`$controllers[$id] = $argumentRef;`
`56`	`59`	`}`