8000 minor #44104 [FrameworkBundle] Fix API gateway service name (jderusse) · symfony/symfony@ca1a431 · GitHub
[go: up one dir, main page]

Skip to content

Commit ca1a431

Browse files
minor #44104 [FrameworkBundle] Fix API gateway service name (jderusse)
This PR was merged into the 5.3 branch. Discussion ---------- [FrameworkBundle] Fix API gateway service name | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Partially revert https://github.com/symfony/symfony/pull/44050/files to restore original names for services. - Changing the name could be a BC break - this is not consistent with other services - it breaks our test suite Symfony\Bundle\FrameworkBundle\Tests\DependencyInjection\PhpFrameworkExtensionTest::testIfNotifierTransportsAreKnownByFrameworkExtension > Did you forget to add the "GatewayApi" TransportFactory to the $classToServices array in FrameworkExtension? > Failed asserting that false is true. Commits ------- ba6126f Fix API gateway service name
2 parents 0f6b07e + ba6126f commit ca1a431

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2421,15 +2421,15 @@ private function registerNotifierConfiguration(array $config, ContainerBuilder $
24212421
$container->getDefinition('notifier.channel_policy')->setArgument(0, $config['channel_policy']);
24222422

24232423
$classToServices = [
2424-
AllMySmsTransportFactory::class => 'notifier.transport_factory.all-my-sms',
2424+
AllMySmsTransportFactory::class => 'notifier.transport_factory.allmysms',
24252425
ClickatellTransportFactory::class => 'notifier.transport_factory.clickatell',
24262426
DiscordTransportFactory::class => 'notifier.transport_factory.discord',
24272427
EsendexTransportFactory::class => 'notifier.transport_factory.esendex',
24282428
FakeChatTransportFactory::class => 'notifier.transport_factory.fakechat',
24292429
FakeSmsTransportFactory::class => 'notifier.transport_factory.fakesms',
24302430
FirebaseTransportFactory::class => 'notifier.transport_factory.firebase',
24312431
FreeMobileTransportFactory::class => 'notifier.transport_factory.freemobile',
2432-
GatewayApiTransportFactory::class => 'notifier.transport_factory.gateway-api',
2432+
GatewayApiTransportFactory::class => 'notifier.transport_factory.gatewayapi',
24332433
GitterTransportFactory::class => 'notifier.transport_factory.gitter',
24342434
GoogleChatTransportFactory::class => 'notifier.transport_factory.googlechat',
24352435
InfobipTransportFactory::class => 'notifier.transport_factory.infobip',

src/Symfony/Bundle/FrameworkBundle/Resources/config/notifier_transports.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@
8585
->parent('notifier.transport_factory.abstract')
8686
->tag('texter.transport_factory')
8787

88-
->set('notifier.transport_factory.all-my-sms', AllMySmsTransportFactory::class)
88+
->set('notifier.transport_factory.allmysms', AllMySmsTransportFactory::class)
8989
->parent('notifier.transport_factory.abstract')
9090
->tag('texter.transport_factory')
9191

@@ -157,7 +157,7 @@
157157
->parent('notifier.transport_factory.abstract')
158158
->tag('chatter.transport_factory')
159159

160-
->set('notifier.transport_factory.gateway-api', GatewayApiTransportFactory::class)
160+
->set('notifier.transport_factory.gatewayapi', GatewayApiTransportFactory::class)
161161
->parent('notifier.transport_factory.abstract')
162162
->tag('texter.transport_factory')
163163

0 commit comments

Comments
 (0)
0