[HttpKernel] Provide status code in fragment handler exception

gonzalovilaseca · gonzalovilaseca · commit c96645669a06 · 2020-07-09T20:23:48.000+02:00
diff --git a/src/Symfony/Component/HttpKernel/Fragment/FragmentHandler.php b/src/Symfony/Component/HttpKernel/Fragment/FragmentHandler.php
@@ -97,7 +97,8 @@ public function render($uri, string $renderer = 'inline', array $options = [])
     protected function deliver(Response $response)
     {
         if (!$response->isSuccessful()) {
-            throw new \RuntimeException(sprintf('Error when rendering "%s" (Status code is %d).', $this->requestStack->getCurrentRequest()->getUri(), $response->getStatusCode()));
+            $responseStatusCode = $response->getStatusCode();
+            throw new \RuntimeException(sprintf('Error when rendering "%s" (Status code is %d).', $this->requestStack->getCurrentRequest()->getUri(), $responseStatusCode), $responseStatusCode);
         }
 
         if (!$response instanceof StreamedResponse) {
diff --git a/src/Symfony/Component/HttpKernel/Tests/Fragment/FragmentHandlerTest.php b/src/Symfony/Component/HttpKernel/Tests/Fragment/FragmentHandlerTest.php
@@ -55,6 +55,7 @@ public function testDeliverWithUnsuccessfulResponse()
     {
         $this->expectException('RuntimeException');
         $this->expectExceptionMessage('Error when rendering "http://localhost/" (Status code is 404).');
+        $this->expectExceptionCode(404);
         $handler = $this->getHandler($this->returnValue(new Response('foo', 404)));
 
         $handler->render('/', 'foo');

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,8 @@ public function render($uri, string $renderer = 'inline', array $options = [])`
`97`	`97`	`protected function deliver(Response $response)`
`98`	`98`	`{`
`99`	`99`	`if (!$response->isSuccessful()) {`
`100`		`- throw new \RuntimeException(sprintf('Error when rendering "%s" (Status code is %d).', $this->requestStack->getCurrentRequest()->getUri(), $response->getStatusCode()));`
	`100`	`+ $responseStatusCode = $response->getStatusCode();`
	`101`	`+ throw new \RuntimeException(sprintf('Error when rendering "%s" (Status code is %d).', $this->requestStack->getCurrentRequest()->getUri(), $responseStatusCode), $responseStatusCode);`
`101`	`102`	`}`
`102`	`103`
`103`	`104`	`if (!$response instanceof StreamedResponse) {`
Original file line number	Diff line number	Diff line change
`@@ -55,6 +55,7 @@ public function testDeliverWithUnsuccessfulResponse()`
`55`	`55`	`{`
`56`	`56`	`$this->expectException('RuntimeException');`
`57`	`57`	`$this->expectExceptionMessage('Error when rendering "http://localhost/" (Status code is 404).');`
	`58`	`+ $this->expectExceptionCode(404);`
`58`	`59`	`$handler = $this->getHandler($this->returnValue(new Response('foo', 404)));`
`59`	`60`
`60`	`61`	`$handler->render('/', 'foo');`