8000 minor #23841 [DebugBundle] Reword an outdated comment about var dumpe… · symfony/symfony@c951ca6 · GitHub
[go: up one dir, main page]

Skip to content

Commit c951ca6

Browse files
minor #23841 [DebugBundle] Reword an outdated comment about var dumper wiring (ogizanagi)
This PR was merged into the 2.7 branch. Discussion ---------- [DebugBundle] Reword an outdated comment about var dumper wiring | Q | A | ------------- | --- | Branch? | 2.7 <!-- see comment below --> | Bug fix? | no | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | no | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A This comment is outdated since #19647, as the default config is now the one used all the way through in HTTP mode, while it's overridden in CLI mode by the `DumpListener` on `console.command` event. Commits ------- f876fd9 [DebugBundle] Reword an outdated comment about var dumper wiring
2 parents 9c84776 + f876fd9 commit c951ca6

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/Symfony/Bundle/DebugBundle/DebugBundle.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,10 @@ public function boot()
2727
$container = $this->container;
2828

2929
// This code is here to lazy load the dump stack. This default
30-
// configuration for CLI mode is overridden in HTTP mode on
31-
// 'kernel.request' event
30+
// configuration is overridden in CLI mode on 'console.command' event.
31+
// The dump data collector is used by default, so dump output is sent to
32+
// the WDT. In a CLI context, if dump is used too soon, the data collector
33+
// will buffer it, and release it at the end of the script.
3234
VarDumper::setHandler(function ($var) use ($container) {
3335
$dumper = $container->get('data_collector.dump');
3436
$cloner = $container->get('var_dumper.cloner');

0 commit comments

Comments
 (0)
0