bug #33727 [HttpClient] workaround bad Content-Length sent by old libcurl (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit c8dbd1ad757c · 2019-09-26T23:18:02.000+02:00
This PR was merged into the 4.3 branch. Discussion ---------- [HttpClient] workaround bad Content-Length sent by old libcurl | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Issue described in https://curl.haxx.se/mail/lib-2014-01/0106.html, happens with curl 7.29 at least. Commits ------- b8d2496 [HttpClient] workaround bad Content-Length sent by old libcurl
diff --git a/src/Symfony/Component/HttpClient/CurlHttpClient.php b/src/Symfony/Component/HttpClient/CurlHttpClient.php
@@ -245,7 +245,7 @@ public function request(string $method, string $url, array $options = []): Respo
             if ('POST' !== $method) {
                 $curlopts[CURLOPT_UPLOAD] = true;
             }
-        } elseif ('' !== $body) {
+        } elseif ('' !== $body || 'POST' === $method) {
             $curlopts[CURLOPT_POSTFIELDS] = $body;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -245,7 +245,7 @@ public function request(string $method, string $url, array $options = []): Respo`
`245`	`245`	`if ('POST' !== $method) {`
`246`	`246`	`$curlopts[CURLOPT_UPLOAD] = true;`
`247`	`247`	`}`
`248`		`- } elseif ('' !== $body) {`
	`248`	`+ } elseif ('' !== $body \|\| 'POST' === $method) {`
`249`	`249`	`$curlopts[CURLOPT_POSTFIELDS] = $body;`
`250`	`250`	`}`
`251`	`251`