bug #60806 [HttpClient] Limit curl's connection cache size (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit c69616dd69df · 2025-06-18T10:47:19.000+02:00
This PR was merged into the 6.4 branch. Discussion ---------- [HttpClient] Limit curl's connection cache size | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | #60513 | License | MIT Trying to accommodate for both #58278 and #60513 By default, $maxHostConnections is 6, so that this allows 50x6 = 300 connections max, which means one third of the typical `ulimit -n` (max open file descriptors), which is 1024. We could allow setting both options separately, but for now, as a bugfix, this might be enough. Commits ------- dfbe6c8 [HttpClient] Limit curl's connection cache size
diff --git a/src/Symfony/Component/HttpClient/Internal/CurlClientState.php b/src/Symfony/Component/HttpClient/Internal/CurlClientState.php
@@ -50,7 +50,7 @@ public function __construct(int $maxHostConnections, int $maxPendingPushes)
             curl_multi_setopt($this->handle, \CURLMOPT_PIPELINING, \CURLPIPE_MULTIPLEX);
         }
         if (\defined('CURLMOPT_MAX_HOST_CONNECTIONS') && 0 < $maxHostConnections) {
-            $maxHostConnections = curl_multi_setopt($this->handle, \CURLMOPT_MAX_HOST_CONNECTIONS, $maxHostConnections) ? 4294967295 : $maxHostConnections;
+            $maxHostConnections = curl_multi_setopt($this->handle, \CURLMOPT_MAX_HOST_CONNECTIONS, $maxHostConnections) ? min(50 * $maxHostConnections, 4294967295) : $maxHostConnections;
         }
         if (\defined('CURLMOPT_MAXCONNECTS') && 0 < $maxHostConnections) {
             curl_multi_setopt($this->handle, \CURLMOPT_MAXCONNECTS, $maxHostConnections);

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ public function __construct(int $maxHostConnections, int $maxPendingPushes)`
`50`	`50`	`curl_multi_setopt($this->handle, \CURLMOPT_PIPELINING, \CURLPIPE_MULTIPLEX);`
`51`	`51`	`}`
`52`	`52`	`if (\defined('CURLMOPT_MAX_HOST_CONNECTIONS') && 0 < $maxHostConnections) {`
`53`		`- $maxHostConnections = curl_multi_setopt($this->handle, \CURLMOPT_MAX_HOST_CONNECTIONS, $maxHostConnections) ? 4294967295 : $maxHostConnections;`
	`53`	`+ $maxHostConnections = curl_multi_setopt($this->handle, \CURLMOPT_MAX_HOST_CONNECTIONS, $maxHostConnections) ? min(50 * $maxHostConnections, 4294967295) : $maxHostConnections;`
`54`	`54`	`}`
`55`	`55`	`if (\defined('CURLMOPT_MAXCONNECTS') && 0 < $maxHostConnections) {`
`56`	`56`	`curl_multi_setopt($this->handle, \CURLMOPT_MAXCONNECTS, $maxHostConnections);`