[HttpClient] Fixing sending content type based on CURLOPT_INFILESIZE

alexandre-daubois · alexandre-daubois · commit c67a689de180 · 2024-05-06T10:29:11.000+02:00
diff --git a/src/Symfony/Component/HttpClient/CurlHttpClient.php b/src/Symfony/Component/HttpClient/CurlHttpClient.php
@@ -252,8 +252,9 @@ public function request(string $method, string $url, array $options = []): Respo
 
             if ('POST' !== $method) {
                 $curlopts[\CURLOPT_UPLOAD] = true;
+                $inFileSize = $curlopts[\CURLOPT_INFILESIZE] ?? -1;
 
-                if (!isset($options['normalized_headers']['content-type']) && 0 !== ($curlopts[\CURLOPT_INFILESIZE] ?? null)) {
+                if (!isset($options['normalized_headers']['content-type']) && 0 > $inFileSize) {
                     $curlopts[\CURLOPT_HTTPHEADER][] = 'Content-Type: application/x-www-form-urlencoded';
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -252,8 +252,9 @@ public function request(string $method, string $url, array $options = []): Respo`
`252`	`252`
`253`	`253`	`if ('POST' !== $method) {`
`254`	`254`	`$curlopts[\CURLOPT_UPLOAD] = true;`
	`255`	`+ $inFileSize = $curlopts[\CURLOPT_INFILESIZE] ?? -1;`
`255`	`256`
`256`		`- if (!isset($options['normalized_headers']['content-type']) && 0 !== ($curlopts[\CURLOPT_INFILESIZE] ?? null)) {`
	`257`	`+ if (!isset($options['normalized_headers']['content-type']) && 0 > $inFileSize) {`
`257`	`258`	`$curlopts[\CURLOPT_HTTPHEADER][] = 'Content-Type: application/x-www-form-urlencoded';`
`258`	`259`	`}`
`259`	`260`	`}`