minor #38004 [Translation] skip tests if required class does not exist (xabbuh)

fabpot · fabpot · commit c649bfa9d48a · 2020-08-31T13:57:12.000+02:00
This PR was merged into the 5.2-dev branch. Discussion ---------- [Translation] skip tests if required class does not exist | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Commits ------- 427fffa skip tests if required class does not exist
diff --git a/src/Symfony/Component/Translation/Tests/TranslatorCacheTest.php b/src/Symfony/Component/Translation/Tests/TranslatorCacheTest.php
@@ -59,6 +59,10 @@ protected function deleteTmpDir()
      */
     public function testThatACacheIsUsed($debug)
     {
+        if (!class_exists(\MessageFormatter::class)) {
+            $this->markTestSkipped(sprintf('Skipping test as the required "%s" class does not exist. Consider installing the "intl" PHP extension or the "symfony/polyfill-intl-messageformatter" package.', \MessageFormatter::class));
+        }
+
         $locale = 'any_locale';
         $format = 'some_format';
         $msgid = 'test';
diff --git a/src/Symfony/Component/Translation/Tests/TranslatorTest.php b/src/Symfony/Component/Translation/Tests/TranslatorTest.php
@@ -373,6 +373,10 @@ public function testTrans($expected, $id, $translation, $parameters, $locale, $d
      */
     public function testTransICU(...$args)
     {
+        if (!class_exists(\MessageFormatter::class)) {
+            $this->markTestSkipped(sprintf('Skipping test as the required "%s" class does not exist. Consider installing the "intl" PHP extension or the "symfony/polyfill-intl-messageformatter" package.', \MessageFormatter::class));
+        }
+
         $this->testTrans(...$args);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -373,6 +373,10 @@ public function testTrans($expected, $id, $translation, $parameters, $locale, $d`
`373`	`373`	`*/`
`374`	`374`	`public function testTransICU(...$args)`
`375`	`375`	`{`
	`376`	`+ if (!class_exists(\MessageFormatter::class)) {`
	`377`	`+ $this->markTestSkipped(sprintf('Skipping test as the required "%s" class does not exist. Consider installing the "intl" PHP extension or the "symfony/polyfill-intl-messageformatter" package.', \MessageFormatter::class));`
	`378`	`+ }`
	`379`	`+`
`376`	`380`	`$this->testTrans(...$args);`
`377`	`381`	`}`
`378`	`382`