10000 adressed feedback from fabpot · symfony/symfony@c5ed83b · GitHub
[go: up one dir, main page]

Skip to content

Commit c5ed83b

Browse files
committed
adressed feedback from fabpot
1 parent d4246e8 commit c5ed83b

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

src/Symfony/Component/DependencyInjection/Compiler/AutoAliasServicePass.php

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -26,30 +26,30 @@ class AutoAliasServicePass implements CompilerPassInterface
2626
*/
2727
public function process(ContainerBuilder $container)
2828
{
29-
foreach ($container->findTaggedServiceIds('auto_alias') as $service_id => $tags) {
29+
foreach ($container->findTaggedServiceIds('auto_alias') as $serviceId => $tags) {
3030
// We don't want to deal with an existing alias.
31-
if ($container->hasAlias($service_id)) {
31+
if ($container->hasAlias($serviceId)) {
3232
continue;
3333
}
3434
foreach ($tags as $tag) {
3535
if (!isset($tag['parameter_name'])) {
36-
throw new ParameterNotFoundException(sprintf('Missing tag information "parameter_name" on auto_alias service %s', $service_id));
36+
throw new ParameterNotFoundException(sprintf('Missing tag information "parameter_name" on auto_alias service "%s".', $serviceId));
3737
}
3838

39-
$parameter_name = $tag['parameter_name'];
40-
if (!$container->hasParameter($parameter_name)) {
41-
throw new ParameterNotFoundException(sprintf('Missing parameter %s', $parameter_name));
39+
$parameterName = $tag['parameter_name'];
40+
if (!$container->hasParameter($parameterName)) {
41+
throw new ParameterNotFoundException(sprintf('Missing parameter "%s"', $parameterName));
4242
}
4343

4444
if (!isset($tag['format'])) {
45-
throw new InvalidArgumentException(sprintf('Missing tag information "format" on auto_alias service %s', $service_id));
45+
throw new InvalidArgumentException(sprintf('Missing tag information "format" on auto_alias service "%s".', $serviceId));
4646
}
4747

48-
$parameter_value = $container->getParameter($parameter_name);
48+
$parameterValue = $container->getParameter($parameterName);
4949
$format = $tag['format'];
50-
$alias_id = str_replace('%s', $parameter_value, $format);
51-
if ($container->hasDefinition($alias_id) || $container->hasAlias($alias_id)) {
52-
$container->setAlias($service_id, new Alias($alias_id));
50+
$aliasId = str_replace('%s', $parameterValue, $format);
51+
if ($container->hasDefinition($aliasId) || $container->hasAlias($aliasId)) {
52+
$container->setAlias($serviceId, new Alias($aliasId));
5353
}
5454
}
5555
}

0 commit comments

Comments
 (0)
0