minor #59695 [HttpClient] pass CURLOPT_INFILESIZE_LARGE only when supported (xabbuh)

nicolas-grekas · nicolas-grekas · commit c33333bb99b4 · 2025-02-04T18:11:05.000+01:00
This PR was merged into the 6.4 branch. Discussion ---------- [HttpClient] pass CURLOPT_INFILESIZE_LARGE only when supported | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT following #59654 Commits ------- 018a384 pass CURLOPT_INFILESIZE_LARGE only when supported
diff --git a/src/Symfony/Component/HttpClient/CurlHttpClient.php b/src/Symfony/Component/HttpClient/CurlHttpClient.php
@@ -316,8 +316,8 @@ public function request(string $method, string $url, array $options = []): Respo
         }
 
         foreach ($curlopts as $opt => $value) {
-            if (\CURLOPT_INFILESIZE === $opt && $value >= 1 << 31) {
-                $opt = 115; // 115 === CURLOPT_INFILESIZE_LARGE, but it's not defined in PHP
+            if (\PHP_INT_SIZE === 8 && \defined('CURLOPT_INFILESIZE_LARGE') && \CURLOPT_INFILESIZE === $opt && $value >= 1 << 31) {
+                $opt = \CURLOPT_INFILESIZE_LARGE;
             }
             if (null !== $value && !curl_setopt($ch, $opt, $value) && \CURLOPT_CERTINFO !== $opt && (!\defined('CURLOPT_HEADEROPT') || \CURLOPT_HEADEROPT !== $opt)) {
                 $constantName = $this->findConstantName($opt);

Original file line number	Diff line number	Diff line change
`@@ -316,8 +316,8 @@ public function request(string $method, string $url, array $options = []): Respo`
`316`	`316`	`}`
`317`	`317`
`318`	`318`	`foreach ($curlopts as $opt => $value) {`
`319`		`- if (\CURLOPT_INFILESIZE === $opt && $value >= 1 << 31) {`
`320`		`- $opt = 115; // 115 === CURLOPT_INFILESIZE_LARGE, but it's not defined in PHP`
	`319`	`+ if (\PHP_INT_SIZE === 8 && \defined('CURLOPT_INFILESIZE_LARGE') && \CURLOPT_INFILESIZE === $opt && $value >= 1 << 31) {`
	`320`	`+ $opt = \CURLOPT_INFILESIZE_LARGE;`
`321`	`321`	`}`
`322`	`322`	`if (null !== $value && !curl_setopt($ch, $opt, $value) && \CURLOPT_CERTINFO !== $opt && (!\defined('CURLOPT_HEADEROPT') \|\| \CURLOPT_HEADEROPT !== $opt)) {`
`323`	`323`	`$constantName = $this->findConstantName($opt);`