bug #31382 [PhpunitBridge] Fix not unserialized logs after DeprecationErrorHandler refacto (l-vo)

nicolas-grekas · nicolas-grekas · commit c315767b6976 · 2019-05-05T18:12:56.000+02:00
This PR was merged into the 4.3-dev branch. Discussion ---------- [PhpunitBridge] Fix not unserialized logs after DeprecationErrorHandler refacto | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | During the refactoring for #29211 , it seems a little bug was introduced. When using runInSeparateProcess, deprecation message isn't unserialized anymore. Commits ------- f522729 [PhpunitBridge] Fix not unserialized logs after DeprecationErrorHandler refactoring
diff --git a/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler.php b/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler.php
@@ -133,6 +133,7 @@ public function handleError($type, $msg, $file, $line, $context = [])
         if ($deprecation->originatesFromAnObject()) {
             $class = $deprecation->originatingClass();
             $method = $deprecation->originatingMethod();
+            $msg = $deprecation->getMessage();
 
             if (0 !== error_reporting()) {
                 $group = 'unsilenced';
diff --git a/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Deprecation.php b/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Deprecation.php
@@ -133,6 +133,11 @@ public function originatingMethod()
         return $this->originMethod;
     }
 
+    public function getMessage(): string
+    {
+        return $this->message;
+    }
+
     /**
      * @param string $utilPrefix
      *

Original file line number	Diff line number	Diff line change
`@@ -133,6 +133,11 @@ public function originatingMethod()`
`133`	`133`	`return $this->originMethod;`
`134`	`134`	`}`
`135`	`135`
	`136`	`+ public function getMessage(): string`
	`137`	`+ {`
	`138`	`+ return $this->message;`
	`139`	`+ }`
	`140`	`+`
`136`	`141`	`/**`
`137`	`142`	`* @param string $utilPrefix`
`138`	`143`	`*`