bug #50493 [VarDumper] Use documentElement instead of body for JS flag (ohader)

nicolas-grekas · nicolas-grekas · commit c31276ba2a8c · 2023-05-31T12:04:58.000+02:00
This PR was merged into the 6.3 branch. Discussion ---------- [VarDumper] Use documentElement instead of body for JS flag | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #50487 | License | MIT | Doc PR | --- Fixes: #50487 Using `document.documentElement` allows to use the dumper outside of a `<html><body>...</body></html>` scenario. Commits ------- 91e6e57 [VarDumper] Use documentElement instead of body for JS flag
diff --git a/src/Symfony/Component/VarDumper/Dumper/HtmlDumper.php b/src/Symfony/Component/VarDumper/Dumper/HtmlDumper.php
@@ -163,9 +163,7 @@ protected function getDumpHeader()
 <script>
 Sfdump = window.Sfdump || (function (doc) {
 
-if (doc.body instanceof HTMLElement) {
-    doc.body.classList.add('sf-js-enabled');
-}
+doc.documentElement.classList.add('sf-js-enabled');
 
 var rxEsc = /([.*+?^${}()|\[\]\/\\])/g,
     idRx = /\bsf-dump-\d+-ref[012]\w+\b/,
