bug #35537 [Config][XmlReferenceDumper] Prevent potential \TypeError (fancyweb)

nicolas-grekas · nicolas-grekas · commit c29989d69e7d · 2020-02-03T18:14:20.000+01:00
This PR was merged into the 4.4 branch. Discussion ---------- [Config][XmlReferenceDumper] Prevent potential \TypeError | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #34841 | License | MIT | Doc PR | - `$key` can be null and `setName()` is now typed with `string`. Fallbacking on an empty string restores the behavior (and output) of < 5.0. However, that shows that's a case we don't handle (yet) properly. But that's another task 😃 Commits ------- e8ba15e [Config][XmlReferenceDumper] Prevent potential \TypeError
diff --git a/src/Symfony/Component/Config/Definition/Dumper/XmlReferenceDumper.php b/src/Symfony/Component/Config/Definition/Dumper/XmlReferenceDumper.php
@@ -91,7 +91,7 @@ private function writeNode(NodeInterface $node, int $depth = 0, bool $root = fal
                 }
 
                 if ($prototype instanceof PrototypedArrayNode) {
-                    $prototype->setName($key);
+                    $prototype->setName($key ?? '');
                     $children = [$key => $prototype];
                 } elseif ($prototype instanceof ArrayNode) {
                     $children = $prototype->getChildren();

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ private function writeNode(NodeInterface $node, int $depth = 0, bool $root = fal`
`91`	`91`	`}`
`92`	`92`
`93`	`93`	`if ($prototype instanceof PrototypedArrayNode) {`
`94`		`- $prototype->setName($key);`
	`94`	`+ $prototype->setName($key ?? '');`
`95`	`95`	`$children = [$key => $prototype];`
`96`	`96`	`} elseif ($prototype instanceof ArrayNode) {`
`97`	`97`	`$children = $prototype->getChildren();`