8000 Rename getIngore and isIgnored · symfony/symfony@c0cb6a7 · GitHub
[go: up one dir, main page]
Skip to content

Commit c0cb6a7

Browse files
dunglasdunglas
committed
Rename getIngore and isIgnored
1 parent 0a9cdce commit c0cb6a7

File tree

8 files changed

+16
-16
lines changed

8 files changed

+16
-16
lines changed

‎src/Symfony/Component/PropertyInfo/Extractor/SerializerExtractor.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ public function getProperties(string $class, array $context = []): ?array
4747
$serializerClassMetadata = $this->classMetadataFactory->getMetadataFor($class);
4848

4949
foreach ($serializerClassMetadata->getAttributesMetadata() as $serializerAttributeMetadata) {
50-
$ignored = method_exists($serializerClassMetadata, 'getIgnore') && $serializerAttributeMetadata->getIgnore();
50+
$ignored = method_exists($serializerClassMetadata, 'getIgnore') && $serializerAttributeMetadata->isIgnored();
5151
if (!$ignored && array_intersect($context['serializer_groups'], $serializerAttributeMetadata->getGroups())) {
5252
$properties[] = $serializerAttributeMetadata->getName();
5353
}

‎src/Symfony/Component/Serializer/Mapping/AttributeMetadata.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ class AttributeMetadata implements AttributeMetadataInterface
5555
*
5656
* @internal This property is public in order to reduce the size of the
5757
* class' serialized representation. Do not access it. Use
58-
* {@link getIgnore()} instead.
58+
* {@link isIgnored()} instead.
5959
*/
6060
public $ignore = false;
6161

@@ -133,7 +133,7 @@ public function setIgnore(bool $ignore)
133133
/**
134134
* {@inheritdoc}
135135
*/
136-
public function getIgnore(): bool
136+
public function isIgnored(): bool
137137
{
138138
return $this->ignore;
139139
}
@@ -157,7 +157,7 @@ public function merge(AttributeMetadataInterface $attributeMetadata)
157157
$this->serializedName = $attributeMetadata->getSerializedName();
158158
}
159159

160-
if ($ignore = $attributeMetadata->getIgnore()) {
160+
if ($ignore = $attributeMetadata->isIgnored()) {
161161
$this->ignore = $ignore;
162162
}
163163
}

‎src/Symfony/Component/Serializer/Mapping/AttributeMetadataInterface.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,9 @@ public function getSerializedName(): ?string;
6767
public function setIgnore(bool $ignore);
6868

6969
/**
70-
* Gets if this attribute must be ignored or not.
70+
* Gets if this attribute is ignored or not.
7171
*/
72-
public function getIgnore(): bool;
72+
public function isIgnored(): bool;
7373

7474
/**
7575
* Merges an {@see AttributeMetadataInterface} with in the current one.

‎src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,7 @@ protected function getAllowedAttributes($classOrObject, array $context, bool $at
243243
$allowedAttributes = [];
244244
$ignoreUsed = false;
245245
foreach ($this->classMetadataFactory->getMetadataFor($classOrObject)->getAttributesMetadata() as $attributeMetadata) {
246-
if ($ignore = $attributeMetadata->getIgnore()) {
246+
if ($ignore = $attributeMetadata->isIgnored()) {
247247
$ignoreUsed = true;
248248
}
249249

‎src/Symfony/Component/Serializer/Tests/Mapping/AttributeMetadataTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,9 @@ public function testSerializedName()
6060
public function testIgnore()
6161
{
6262
$attributeMetadata = new AttributeMetadata('ignored');
63-
$this->assertFalse($attributeMetadata->getIgnore());
63+
$this->assertFalse($attributeMetadata->isIgnored());
6464
$attributeMetadata->setIgnore(true);
65-
$this->assertTrue($attributeMetadata->getIgnore());
65+
$this->assertTrue($attributeMetadata->isIgnored());
6666
}
6767

6868
public function testMerge()
@@ -84,7 +84,7 @@ public function testMerge()
8484
$this->assertEquals(['a', 'b', 'c'], $attributeMetadata1->getGroups());
8585
$this->assertEquals(2, $attributeMetadata1->getMaxDepth());
8686
$this->assertEquals('a3', $attributeMetadata1->getSerializedName());
87-
$this->assertTrue($attributeMetadata1->getIgnore());
87+
$this->assertTrue($attributeMetadata1->isIgnored());
8888
}
8989

9090
public function testSerialize()

‎src/Symfony/Component/Serializer/Tests/Mapping/Loader/AnnotationLoaderTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ public function testLoadIgnore()
113113
$this->loader->loadClassMetadata($classMetadata);
114114

115115
$attributesMetadata = $classMetadata->getAttributesMetadata();
116-
$this->assertTrue($attributesMetadata['ignored1']->getIgnore());
117-
$this->assertTrue($attributesMetadata['ignored2']->getIgnore());
116+
$this->assertTrue($attributesMetadata['ignored1']->isIgnored());
117+
$this->assertTrue($attributesMetadata['ignored2']->isIgnored());
118118
}
119119
}

‎src/Symfony/Component/Serializer/Tests/Mapping/Loader/XmlFileLoaderTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ public function testLoadIgnore()
100100
$this->loader->loadClassMetadata($classMetadata);
101101

102102
$attributesMetadata = $classMetadata->getAttributesMetadata();
103-
$this->assertTrue($attributesMetadata['ignored1']->getIgnore());
104-
$this->assertTrue($attributesMetadata['ignored2']->getIgnore());
103+
$this->assertTrue($attributesMetadata['ignored1']->isIgnored());
104+
$this->assertTrue($attributesMetadata['ignored2']->isIgnored());
105105
}
106106
}

‎src/Symfony/Component/Serializer/Tests/Mapping/Loader/YamlFileLoaderTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,8 +114,8 @@ public function testLoadIgnore()
114114
$this->loader->loadClassMetadata($classMetadata);
115115

116116
$attributesMetadata = $classMetadata->getAttributesMetadata();
117-
$this->assertTrue($attributesMetadata['ignored1']->getIgnore());
118-
$this->assertTrue($attributesMetadata['ignored2']->getIgnore());
117+
$this->assertTrue($attributesMetadata['ignored1']->isIgnored());
118+
$this->assertTrue($attributesMetadata['ignored2']->isIgnored());
119119
}
120120

121121
public function testLoadInvalidIgnore()

0 commit comments

Comments
 (0)
0