bug #37461 [Process] Fix Permission Denied error when writing sf_proc_00 lock files on Windows (JasonStephensTAMU)

nicolas-grekas · nicolas-grekas · commit c0181c76678d · 2020-07-06T15:15:39.000+02:00
This PR was merged into the 3.4 branch. Discussion ---------- [Process] Fix Permission Denied error when writing sf_proc_00 lock files on Windows | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? |no | Deprecations? | no | Tickets | Fix #37294 | License | MIT | Doc PR | Passes current Process unit tests. On Windows systems, a new set of sf_proc_## files are generated in the system temp directory for each WindowsPipes object. These files are removed when the WindowsPipes object is destroyed. This avoids receiving a permission denied error when attempting to write to sf_proc_## files between multiple sites running as different users, when the users do not have permissions to modify each others files. Changes - [Process] WindowsPipes always creates new sf_proc_## files in constructor - [Process] WindowsPipes removes its sf_proc_## files in destructor Commits ------- 220be89 [Process] Fix Permission Denied error when writing sf_proc_00 lock files on Windows
diff --git a/src/Symfony/Component/Process/Pipes/WindowsPipes.php b/src/Symfony/Component/Process/Pipes/WindowsPipes.php
@@ -56,6 +56,9 @@ public function __construct($input, $haveReadSupport)
                     $file = sprintf('%s\\sf_proc_%02X.%s', $tmpDir, $i, $name);
 
                     if (!$h = fopen($file.'.lock', 'w')) {
+                        if (file_exists($file.'.lock')) {
+                            continue 2;
+                        }
                         restore_error_handler();
                         throw new RuntimeException('A temporary file could not be opened to write the process output: '.$lastError);
                     }

Original file line number	Diff line number	Diff line change
`@@ -56,6 +56,9 @@ public function __construct($input, $haveReadSupport)`
`56`	`56`	`$file = sprintf('%s\\sf_proc_%02X.%s', $tmpDir, $i, $name);`
`57`	`57`
`58`	`58`	`if (!$h = fopen($file.'.lock', 'w')) {`
	`59`	`+ if (file_exists($file.'.lock')) {`
	`60`	`+ continue 2;`
	`61`	`+ }`
`59`	`62`	`restore_error_handler();`
`60`	`63`	`throw new RuntimeException('A temporary file could not be opened to write the process output: '.$lastError);`
`61`	`64`	`}`