update locale completion

stephenkhoo · stephenkhoo · commit bfd516f3cfe0 · 2021-10-25T19:27:15.000+08:00
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php
@@ -22,6 +22,7 @@
 use Symfony\Component\Console\Style\SymfonyStyle;
 use Symfony\Component\HttpKernel\Bundle\BundleInterface;
 use Symfony\Component\HttpKernel\KernelInterface;
+use Symfony\Component\Intl\Locales;
 use Symfony\Component\Translation\Catalogue\MergeOperation;
 use Symfony\Component\Translation\Catalogue\TargetOperation;
 use Symfony\Component\Translation\Extractor\ExtractorInterface;
@@ -310,6 +311,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
     public function complete(CompletionInput $input, CompletionSuggestions $suggestions): void
     {
         if ($input->mustSuggestArgumentValuesFor('locale')) {
+            $suggestions->suggestValues(Locales::getLocales());
             return;
         }
 
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/Command/TranslationUpdateCommandCompletionTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/Command/TranslationUpdateCommandCompletionTest.php
@@ -20,6 +20,7 @@
 use Symfony\Component\Filesystem\Filesystem;
 use Symfony\Component\HttpKernel\Bundle\BundleInterface;
 use Symfony\Component\HttpKernel\KernelInterface;
+use Symfony\Component\Intl\Locales;
 use Symfony\Component\Translation\Extractor\ExtractorInterface;
 use Symfony\Component\Translation\Reader\TranslationReader;
 use Symfony\Component\Translation\Translator;
@@ -44,6 +45,7 @@ public function testComplete(array $input, array $expectedSuggestions)
 
     public function provideCompletionSuggestions()
     {
+        yield 'locale' => [[''], Locales::getLocales()];
         yield 'bundle' => [['en', ''], ['BaseBundle']];
         yield 'domain with locale' => [['en', '--domain=m'], ['messages']];
         yield 'domain without locale' => [['--domain=m'], []];

Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,7 @@`
`22`	`22`	`use Symfony\Component\Console\Style\SymfonyStyle;`
`23`	`23`	`use Symfony\Component\HttpKernel\Bundle\BundleInterface;`
`24`	`24`	`use Symfony\Component\HttpKernel\KernelInterface;`
	`25`	`+use Symfony\Component\Intl\Locales;`
`25`	`26`	`use Symfony\Component\Translation\Catalogue\MergeOperation;`
`26`	`27`	`use Symfony\Component\Translation\Catalogue\TargetOperation;`
`27`	`28`	`use Symfony\Component\Translation\Extractor\ExtractorInterface;`
`@@ -310,6 +311,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int`
`310`	`311`	`public function complete(CompletionInput $input, CompletionSuggestions $suggestions): void`
`311`	`312`	`{`
`312`	`313`	`if ($input->mustSuggestArgumentValuesFor('locale')) {`
	`314`	`+ $suggestions->suggestValues(Locales::getLocales());`
`313`	`315`	`return;`
`314`	`316`	`}`
`315`	`317`