8000 minor #58172 Remove no-op `ReflectionProperty::setAccessible()` calls… · symfony/symfony@bf71686 · GitHub
[go: up one dir, main page]

Skip to content

Commit bf71686

Browse files
minor #58172 Remove no-op ReflectionProperty::setAccessible() calls (alexandre-daubois)
This PR was merged into the 7.2 branch. Discussion ---------- Remove no-op `ReflectionProperty::setAccessible()` calls | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT `ReflectionProperty::setAccessible()` is no-op since PHP 8.1. Commits ------- add2048 Remove no-op `ReflectionProperty::setAccessible()` calls
2 parents 14e99f0 + add2048 commit bf71686

File tree

3 files changed

+2
-6
lines changed

3 files changed

+2
-6
lines changed

src/Symfony/Component/ErrorHandler/Tests/ErrorHandlerTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ class ErrorHandlerTest extends TestCase
3434
protected function tearDown(): void
3535
{
3636
$r = new \ReflectionProperty(ErrorHandler::class, 'exitCode');
37-
$r->setAccessible(true);
3837
$r->setValue(null, 0);
3938
}
4039

src/Symfony/Component/Mailer/Tests/Transport/SendmailTransportTest.php

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,8 @@ public function testThrowsTransportExceptionOnFailure()
9494
$sendmailTransport->send($mail, $envelope);
9595

9696
$streamProperty = new \ReflectionProperty(SendmailTransport::class, 'stream');
97-
$streamProperty->setAccessible(true);
9897
$stream = $streamProperty->getValue($sendmailTransport);
98+
9999
$this->assertNull($stream->stream);
100100
}
101101

@@ -112,10 +112,9 @@ public function testStreamIsClearedOnFailure()
112112
}
113113

114114
$streamProperty = new \ReflectionProperty(SendmailTransport::class, 'stream');
115-
$streamProperty->setAccessible(true);
116115
$stream = $streamProperty->getValue($sendmailTransport);
117116
$ CC66 innerStreamProperty = new \ReflectionProperty(ProcessStream::class, 'stream');
118-
$innerStreamProperty->setAccessible(true);
117+
119118
$this->assertNull($innerStreamProperty->getValue($stream));
120119
}
121120

@@ -127,7 +126,6 @@ public function testDoesNotThrowWhenInteractive()
127126

128127
$sendmailTransport = new SendmailTransport(self::FAKE_INTERACTIVE_SENDMAIL);
129128
$transportProperty = new \ReflectionProperty(SendmailTransport::class, 'transport');
130-
$transportProperty->setAccessible(true);
131129

132130
// Replace the transport with an anonymous consumer that trigger the stream methods
133131
$transportProperty->setValue($sendmailTransport, new class($transportProperty->getValue($sendmailTransport)->getStream()) extends SmtpTransport {

src/Symfony/Component/Notifier/Bridge/Bluesky/Tests/BlueskyTransportTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,6 @@ private function parseFacets(string $input, ?HttpClientInterface $httpClient = n
323323
{
324324
$class = new \ReflectionClass(BlueskyTransport::class);
325325
$method = $class->getMethod('parseFacets');
326-
$method->setAccessible(true);
327326

328327
$object = $class->newInstance('user', 'pass', new NullLogger(), $httpClient ?? new MockHttpClient([]));
329328

0 commit comments

Comments
 (0)
0