[Webhook] Add readonly modifier where this possible

onEXHovia · onEXHovia · commit bf4ad40178f4 · 2023-03-20T15:32:29.000+07:00
diff --git a/src/Symfony/Component/Webhook/Controller/WebhookController.php b/src/Symfony/Component/Webhook/Controller/WebhookController.php
@@ -30,8 +30,8 @@ final class WebhookController
 {
     public function __construct(
         /** @var array<string, array{parser: RequestParserInterface, secret: string}> $parsers */
-        private array $parsers,
-        private MessageBusInterface $bus,
+        private readonly array $parsers,
+        private readonly MessageBusInterface $bus,
     ) {
     }
 
diff --git a/src/Symfony/Component/Webhook/Server/HeaderSignatureConfigurator.php b/src/Symfony/Component/Webhook/Server/HeaderSignatureConfigurator.php
@@ -23,8 +23,8 @@
 final class HeaderSignatureConfigurator implements RequestConfiguratorInterface
 {
     public function __construct(
-        private string $algo = 'sha256',
-        private string $signatureHeaderName = 'Webhook-Signature',
+        private readonly string $algo = 'sha256',
+        private readonly string $signatureHeaderName = 'Webhook-Signature',
     ) {
     }
 
diff --git a/src/Symfony/Component/Webhook/Server/HeadersConfigurator.php b/src/Symfony/Component/Webhook/Server/HeadersConfigurator.php
@@ -22,8 +22,8 @@
 final class HeadersConfigurator implements RequestConfiguratorInterface
 {
     public function __construct(
-        private string $eventHeaderName = 'Webhook-Event',
-        private string $idHeaderName = 'Webhook-Id',
+        private readonly string $eventHeaderName = 'Webhook-Event',
+        private readonly string $idHeaderName = 'Webhook-Id',
     ) {
     }
 
diff --git a/src/Symfony/Component/Webhook/Subscriber.php b/src/Symfony/Component/Webhook/Subscriber.php
@@ -14,8 +14,8 @@
 class Subscriber
 {
     public function __construct(
-        private string $url,
-        #[\SensitiveParameter] private string $secret,
+        private readonly string $url,
+        #[\SensitiveParameter] private readonly string $secret,
     ) {
     }
 

Original file line number	Diff line number	Diff line change
`@@ -30,8 +30,8 @@ final class WebhookController`
`30`	`30`	`{`
`31`	`31`	`public function __construct(`
`32`	`32`	`/** @var array<string, array{parser: RequestParserInterface, secret: string}> $parsers */`
`33`		`- private array $parsers,`
`34`		`- private MessageBusInterface $bus,`
	`33`	`+ private readonly array $parsers,`
	`34`	`+ private readonly MessageBusInterface $bus,`
`35`	`35`	`) {`
`36`	`36`	`}`
`37`	`37`
Original file line number	Diff line number	Diff line change
`@@ -23,8 +23,8 @@`
`23`	`23`	`final class HeaderSignatureConfigurator implements RequestConfiguratorInterface`
`24`	`24`	`{`
`25`	`25`	`public function __construct(`
`26`		`- private string $algo = 'sha256',`
`27`		`- private string $signatureHeaderName = 'Webhook-Signature',`
	`26`	`+ private readonly string $algo = 'sha256',`
	`27`	`+ private readonly string $signatureHeaderName = 'Webhook-Signature',`
`28`	`28`	`) {`
`29`	`29`	`}`
`30`	`30`
Original file line number	Diff line number	Diff line change
`@@ -22,8 +22,8 @@`
`22`	`22`	`final class HeadersConfigurator implements RequestConfiguratorInterface`
`23`	`23`	`{`
`24`	`24`	`public function __construct(`
`25`		`- private string $eventHeaderName = 'Webhook-Event',`
`26`		`- private string $idHeaderName = 'Webhook-Id',`
	`25`	`+ private readonly string $eventHeaderName = 'Webhook-Event',`
	`26`	`+ private readonly string $idHeaderName = 'Webhook-Id',`
`27`	`27`	`) {`
`28`	`28`	`}`
`29`	`29`
Original file line number	Diff line number	Diff line change
`@@ -14,8 +14,8 @@`
`14`	`14`	`class Subscriber`
`15`	`15`	`{`
`16`	`16`	`public function __construct(`
`17`		`- private string $url,`
`18`		`- #[\SensitiveParameter] private string $secret,`
	`17`	`+ private readonly string $url,`
	`18`	`+ #[\SensitiveParameter] private readonly string $secret,`
`19`	`19`	`) {`
`20`	`20`	`}`
`21`	`21`