bug #50352 [Notifier][TurboSMS] Fix get sender name (ZhukV)

nicolas-grekas · nicolas-grekas · commit bf262b9e82df · 2023-05-18T22:12:00.000+02:00
This PR was merged into the 6.2 branch. Discussion ---------- [Notifier][TurboSMS] Fix get sender name | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | License | MIT Fix get sender name in Turbo Sms Transport. Commits ------- d3486dd Fix get sender name in turbosms notifier
diff --git a/src/Symfony/Component/Notifier/Bridge/TurboSms/Tests/TurboSmsTransportTest.php b/src/Symfony/Component/Notifier/Bridge/TurboSms/Tests/TurboSmsTransportTest.php
@@ -71,7 +71,16 @@ public function testSuccessfulSend()
             ]))
         ;
 
-        $client = new MockHttpClient(static function () use ($response): ResponseInterface {
+        $client = new MockHttpClient(static function (string $method, string $url, array $options) use ($response): ResponseInterface {
+            $body = json_decode($options['body'], true);
+            self::assertSame([
+                'sms' => [
+                    'sender' => 'sender',
+                    'recipients' => ['380931234567'],
+                    'text' => 'Тест/Test',
+                ],
+            ], $body);
+
             return $response;
         });
 
diff --git a/src/Symfony/Component/Notifier/Bridge/TurboSms/TurboSmsTransport.php b/src/Symfony/Component/Notifier/Bridge/TurboSms/TurboSmsTransport.php
@@ -66,7 +66,8 @@ protected function doSend(MessageInterface $message): SentMessage
         $this->assertValidSubject($message->getSubject());
 
         $fromMessage = $message->getFrom();
-        if (null !== $fromMessage) {
+
+        if ($fromMessage) {
             $this->assertValidFrom($fromMessage);
             $from = $fromMessage;
         } else {
