bug #11170 [Console] Fixed notice in QuestionHelper (florianv)

fabpot · fabpot · commit bebd18cbd112 · 2014-06-19T11:31:54.000+02:00
This PR was merged into the 2.5 branch. Discussion ---------- [Console] Fixed notice in QuestionHelper | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT When pressing escape in a question, a notice is shown because the sequence is only 2 characters long. Commits ------- 9fe4b88 [Console] Fixed notice in QuestionHelper
diff --git a/src/Symfony/Component/Console/Helper/QuestionHelper.php b/src/Symfony/Component/Console/Helper/QuestionHelper.php
@@ -212,7 +212,7 @@ private function autocomplete(OutputInterface $output, Question $question, $inpu
                 $c .= fread($inputStream, 2);
 
                 // A = Up Arrow. B = Down Arrow
-                if ('A' === $c[2] || 'B' === $c[2]) {
+                if (isset($c[2]) && ('A' === $c[2] || 'B' === $c[2])) {
                     if ('A' === $c[2] && -1 === $ofs) {
                         $ofs = 0;
                     }

Original file line number	Diff line number	Diff line change
`@@ -212,7 +212,7 @@ private function autocomplete(OutputInterface $output, Question $question, $inpu`
`212`	`212`	`$c .= fread($inputStream, 2);`
`213`	`213`
`214`	`214`	`// A = Up Arrow. B = Down Arrow`
`215`		`- if ('A' === $c[2] \|\| 'B' === $c[2]) {`
	`215`	`+ if (isset($c[2]) && ('A' === $c[2] \|\| 'B' === $c[2])) {`
`216`	`216`	`if ('A' === $c[2] && -1 === $ofs) {`
`217`	`217`	`$ofs = 0;`
`218`	`218`	`}`