minor #26776 [VarDumper] Skip some tests on custom xdebug.file_link_format (ogizanagi)

nicolas-grekas · nicolas-grekas · commit beb90e8264d8 · 2018-04-03T22:34:11.000+02:00
This PR was merged into the 3.4 branch. Discussion ---------- [VarDumper] Skip some tests on custom xdebug.file_link_format | Q | A | ------------- | --- | Branch? | 3.4  | Bug fix? | no | New feature? | no  | BC breaks? | no  | Deprecations? | no  | Tests pass? | yes  | Fixed tickets | N/A  | License | MIT | Doc PR | N/A  Those tests are failing locally if a custom `xdebug.file_link_format` value is set. Let's skip them as for `FrameworkExtensionTest::testFileLinkFormat`. This will prevent some WTF moments and any actual error on these tests will be reported by the CI (IMHO isn't worth the hassle of updating the tests to handle both cases). Commits ------- f9216ed [VarDumper] Skip some tests on custom xdebug.file_link_format
diff --git a/src/Symfony/Component/VarDumper/Tests/Caster/ExceptionCasterTest.php b/src/Symfony/Component/VarDumper/Tests/Caster/ExceptionCasterTest.php
@@ -126,6 +126,10 @@ public function testNoSrcContext()
 
     public function testHtmlDump()
     {
+        if (ini_get('xdebug.file_link_format') || get_cfg_var('xdebug.file_link_format')) {
+            $this->markTestSkipped('A custom file_link_format is defined.');
+        }
+
         $e = $this->getTestException(1);
         ExceptionCaster::$srcContext = -1;
 
diff --git a/src/Symfony/Component/VarDumper/Tests/Dumper/HtmlDumperTest.php b/src/Symfony/Component/VarDumper/Tests/Dumper/HtmlDumperTest.php
@@ -22,6 +22,10 @@ class HtmlDumperTest extends TestCase
 {
     public function testGet()
     {
+        if (ini_get('xdebug.file_link_format') || get_cfg_var('xdebug.file_link_format')) {
+            $this->markTestSkipped('A custom file_link_format is defined.');
+        }
+
         require __DIR__.'/../Fixtures/dumb-var.php';
 
         $dumper = new HtmlDumper('php://output');

Original file line number	Diff line number	Diff line change
`@@ -126,6 +126,10 @@ public function testNoSrcContext()`
`126`	`126`
`127`	`127`	`public function testHtmlDump()`
`128`	`128`	`{`
	`129`	`+ if (ini_get('xdebug.file_link_format') \|\| get_cfg_var('xdebug.file_link_format')) {`
	`130`	`+ $this->markTestSkipped('A custom file_link_format is defined.');`
	`131`	`+ }`
	`132`	`+`
`129`	`133`	`$e = $this->getTestException(1);`
`130`	`134`	`ExceptionCaster::$srcContext = -1;`
`131`	`135`
Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,10 @@ class HtmlDumperTest extends TestCase`
`22`	`22`	`{`
`23`	`23`	`public function testGet()`
`24`	`24`	`{`
	`25`	`+ if (ini_get('xdebug.file_link_format') \|\| get_cfg_var('xdebug.file_link_format')) {`
	`26`	`+ $this->markTestSkipped('A custom file_link_format is defined.');`
	`27`	`+ }`
	`28`	`+`
`25`	`29`	`require __DIR__.'/../Fixtures/dumb-var.php';`
`26`	`30`
`27`	`31`	`$dumper = new HtmlDumper('php://output');`