Fix undefined variable fromConstructor when passing context to getTypes

mantis · mantis · commit be8d14a12917 · 2019-02-23T19:23:31.000Z
If passing context to getTypes, it checks value of $context['enable_constructor_extraction'] for true/false or the constructor value of enableConstructorExtraction and should then populate fromConstructor if necessary. The missing brackets around the first part of this check mean that fromConstructor is only applied if context is not set. This fixes the issuse described at [symfony/symfony-docs#10969](symfony/symfony-docs#10969)
diff --git a/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php b/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php
@@ -112,7 +112,7 @@ public function getTypes($class, $property, array $context = [])
         }
 
         if (
-            $context['enable_constructor_extraction'] ?? $this->enableConstructorExtraction &&
+            ($context['enable_constructor_extraction'] ?? $this->enableConstructorExtraction) &&
             $fromConstructor = $this->extractFromConstructor($class, $property)
         ) {
             return $fromConstructor;

Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,7 @@ public function getTypes($class, $property, array $context = [])`
`112`	`112`	`}`
`113`	`113`
`114`	`114`	`if (`
`115`		`- $context['enable_constructor_extraction'] ?? $this->enableConstructorExtraction &&`
	`115`	`+ ($context['enable_constructor_extraction'] ?? $this->enableConstructorExtraction) &&`
`116`	`116`	`$fromConstructor = $this->extractFromConstructor($class, $property)`
`117`	`117`	`) {`
`118`	`118`	`return $fromConstructor;`