Revert "bug #48027 [DependencyInjection] Don't autoconfigure tag when it's already set with attributes (nicolas-grekas)"

nicolas-grekas · nicolas-grekas · commit bd2780a23724 · 2022-12-05T14:10:54.000+01:00
This reverts commit 67e0e87, reversing changes made to f9eaefa.
diff --git a/src/Symfony/Component/DependencyInjection/Compiler/ResolveInstanceofConditionalsPass.php b/src/Symfony/Component/DependencyInjection/Compiler/ResolveInstanceofConditionalsPass.php
@@ -129,7 +129,7 @@ private function processDefinition(ContainerBuilder $container, string $id, Defi
                 foreach ($instanceofTags[$i] as $k => $v) {
                     if (null === $definition->getDecoratedService() || \in_array($k, $tagsToKeep, true)) {
                         foreach ($v as $v) {
-                            if ($definition->hasTag($k) && (!$v || \in_array($v, $definition->getTag($k)))) {
+                            if ($definition->hasTag($k) && \in_array($v, $definition->getTag($k))) {
                                 continue;
                             }
                             $definition->addTag($k, $v);
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Compiler/IntegrationTest.php b/src/Symfony/Component/DependencyInjection/Tests/Compiler/IntegrationTest.php
@@ -883,7 +883,6 @@ static function (ChildDefinition $definition, CustomAutoconfiguration $attribute
                 $definition->addTag('app.custom_tag', get_object_vars($attribute) + ['class' => $reflector->getName()]);
             }
         );
-        $container->registerForAutoconfiguration(TaggedService1::class)->addTag('app.custom_tag');
 
         $container->register('one', TaggedService1::class)
             ->setPublic(true)

Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,7 @@ private function processDefinition(ContainerBuilder $container, string $id, Defi`
`129`	`129`	`foreach ($instanceofTags[$i] as $k => $v) {`
`130`	`130`	`if (null === $definition->getDecoratedService() \|\| \in_array($k, $tagsToKeep, true)) {`
`131`	`131`	`foreach ($v as $v) {`
`132`		`- if ($definition->hasTag($k) && (!$v \|\| \in_array($v, $definition->getTag($k)))) {`
	`132`	`+ if ($definition->hasTag($k) && \in_array($v, $definition->getTag($k))) {`
`133`	`133`	`continue;`
`134`	`134`	`}`
`135`	`135`	`$definition->addTag($k, $v);`
Original file line number	Diff line number	Diff line change
`@@ -883,7 +883,6 @@ static function (ChildDefinition $definition, CustomAutoconfiguration $attribute`
`883`	`883`	`$definition->addTag('app.custom_tag', get_object_vars($attribute) + ['class' => $reflector->getName()]);`
`884`	`884`	`}`
`885`	`885`	`);`
`886`		`- $container->registerForAutoconfiguration(TaggedService1::class)->addTag('app.custom_tag');`
`887`	`886`
`888`	`887`	`$container->register('one', TaggedService1::class)`
`889`	`888`	`->setPublic(true)`